fix: Fixes for Open X Facts strings #12569
Open
+232
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
|
@copilot can you address the todo I added ? |
The manifest.pl PWA manifest was using a generic `site_description`
translation key instead of flavor-specific keys, causing all flavors
(OFF, OBF, OPF, OPFF) to share the same description.
### Changes
- Updated `cgi/manifest.pl` to use `lang("site_description_$flavor")`
instead of `lang('site_description')`
- Removed TODO comment requesting this fix
- Leverages existing `$flavor` variable from `ProductOpener::Config`
module
- Aligns with pattern used in `Display.pm` for flavor-specific metadata
```perl
# Before
description => lang('site_description'),
# After
description => lang("site_description_$flavor"),
```
Each flavor now gets its appropriate description in the PWA manifest
(e.g., "food products" for OFF, "cosmetic products" for OBF, "pet food
products" for OPFF).
<!-- START COPILOT CODING AGENT TIPS -->
---
💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.
---------
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: teolemon <[email protected]>
github-project-automation
bot
moved this to In progress
in 🔎 Improve the search experience
github-project-automation
bot
moved this to Todo
in 🌐 Review & Merge translations across Open Food Facts
teolemon
commented
Oct 29, 2025
| } | ||
|
|
||
| # TODO: flavor specific string | ||
| my $description = lang("search_description_opensearch"); |
There was a problem hiding this comment.
Suggested change
| my $description = lang("search_description_opensearch"); | |
| my $description = lang("search_description_opensearch_$flavor"); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fix: Fixes for Open X Facts strings