fix(build): remove unwanted referenceapplication-demo folder from distribution #941
Conversation
…tro output - Adds Maven Antrun plugin step to delete the redundant referenceapplication-demo folder after SDK build - Ensures demo content is preserved via referencedemodata module - Maintains integrity of build and application functionality - Implements safe, robust, and maintainable solution as per verification and best practices
|
@UjjawalPrabhat what are the exact steps to reproduce the unwanted demo folder? |
Thanks for reviewing! Here’s how to reproduce the unwanted referenceapplication-demo folder:
You will see both: The referenceapplication-demo folder is the unwanted directory. Let me know if you need any more details! |
|
Are you able to reproduce it with the 3.6.0-SNAPSHOT? |
@dkayiwa Apologies for the late response! Yes, I can reproduce the issue with 3.6.0-SNAPSHOT. On main (without fix): The unwanted referenceapplication-demo/ folder appears in the build output. On my fix branch: The folder is successfully removed, leaving only the necessary directories (openmrs_config, openmrs_core, openmrs_modules, etc.). Screenshot: The fix works correctly without affecting other build artifacts or functionality. Demo content remains accessible via the referencedemodata module. |
|
@dkayiwa The E2E test failures appear to be unrelated to this PR. The failing tests (attachments.spec.ts and visit-note.spec.ts) are timing out while waiting for success notifications to appear. Since this PR only modifies the build artifact structure (removing the redundant referenceapplication-demo/ folder), it doesn't affect:
These look like flaky tests that may be affected by CI environment performance or an existing application issue. The fix itself has been verified to work correctly without impacting core functionality. Would you like me to re-run the tests, or should we investigate these notification timeout issues separately? |
| <configuration> | ||
| <target> | ||
| <echo message="Removing unwanted referenceapplication-demo folders from build output..." /> | ||
| <delete dir="${project.build.directory}/sdk-distro/web/referenceapplication-demo" |
There was a problem hiding this comment.
Instead of deleting it, did you explore the option of just not creating it in the very first place?
2 participants
Overview
Removes the redundant
referenceapplication-demodirectory from the OpenMRS distribution build by introducing a Maven Antrun plugin execution post-SDK build. This ensures the demo folder does not appear in the final artifacts, maintaining a clean and correct output.Details
distro/pom.xmlto safely delete thereferenceapplication-demofolder after the build-distro phase.Linked Resource
Checklist