[BUGFIX] changed accept type from .txt to .json,.ndjson in create query sets file upload #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry sets file upload Signed-off-by: venkateshwaran <[email protected]>
venkateshwaracholan
requested review from
bzhangam,
epugh,
fen-qin,
heemin32,
junqiu-lei and
martin-gaievski
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes an issue in the Query Set creation flow where the click-to-upload file picker under Manual Queries did not allow users to select valid
.ndjsonor.jsonfiles. While drag-and-drop worked correctly, the OS file picker was restricted due to an incorrectacceptattribute.The file picker now supports:
.ndjson(primary, recommended format).json(JSON array as a convenience)This ensures consistent behavior between click upload and drag-and-drop and improves overall usability for manual Query Set creation.
Issues Resolved
.ndjsonand.jsonfiles could not be selected via click upload in Query Set creation.Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here:
https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin