Revert Updates toString calls affected by change in method signature (#2460)

cwperks · web-flow · commit 222455fda33a · 2023-02-22T15:19:39.000-05:00
Signed-off-by: Craig Perkins &lt;cwperx@amazon.com&gt;
diff --git a/src/main/java/org/opensearch/security/action/whoami/WhoAmIResponse.java b/src/main/java/org/opensearch/security/action/whoami/WhoAmIResponse.java
@@ -34,7 +34,6 @@
 import org.opensearch.common.io.stream.StreamOutput;
 import org.opensearch.common.xcontent.ToXContent;
 import org.opensearch.common.xcontent.XContentBuilder;
-import org.opensearch.common.xcontent.XContentType;
 
 public class WhoAmIResponse extends ActionResponse implements ToXContent {
     
@@ -106,6 +105,6 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
 
     @Override
     public String toString() {
-        return Strings.toString(XContentType.JSON,this, true, true);
+        return Strings.toString(this, true, true);
     }
 }
diff --git a/src/main/java/org/opensearch/security/configuration/ConfigurationRepository.java b/src/main/java/org/opensearch/security/configuration/ConfigurationRepository.java
@@ -63,7 +63,6 @@
 import org.opensearch.common.settings.Settings;
 import org.opensearch.common.util.concurrent.ThreadContext;
 import org.opensearch.common.util.concurrent.ThreadContext.StoredContext;
-import org.opensearch.common.xcontent.XContentType;
 import org.opensearch.env.Environment;
 import org.opensearch.security.auditlog.AuditLog;
 import org.opensearch.security.auditlog.config.AuditConfig;
@@ -380,7 +379,7 @@ public Map<CType, SecurityDynamicConfiguration<?>> getConfigurationsFromIndex(Co
         if (logComplianceEvent && auditLog.getComplianceConfig().isEnabled()) {
             CType configurationType = configTypes.iterator().next();
             Map<String, String> fields = new HashMap<String, String>();
-            fields.put(configurationType.toLCString(), Strings.toString(XContentType.JSON, retVal.get(configurationType)));
+            fields.put(configurationType.toLCString(), Strings.toString(retVal.get(configurationType)));
             auditLog.logDocumentRead(this.securityIndex, configurationType.toLCString(), null, fields);
         }
 
diff --git a/src/main/java/org/opensearch/security/configuration/DlsFlsValveImpl.java b/src/main/java/org/opensearch/security/configuration/DlsFlsValveImpl.java
@@ -52,7 +52,6 @@
 import org.opensearch.common.settings.Settings;
 import org.opensearch.common.util.concurrent.ThreadContext;
 import org.opensearch.common.xcontent.NamedXContentRegistry;
-import org.opensearch.common.xcontent.XContentType;
 import org.opensearch.index.query.ParsedQuery;
 import org.opensearch.rest.RestStatus;
 import org.opensearch.search.DocValueFormat;
@@ -210,10 +209,10 @@ public boolean invoke(String action, ActionRequest request, final ActionListener
                     StringBuilder sb = new StringBuilder();
 
                     if (searchRequest.source() != null) {
-                        sb.append(Strings.toString(XContentType.JSON, searchRequest.source()) + System.lineSeparator());
+                        sb.append(Strings.toString(searchRequest.source()) + System.lineSeparator());
                     }
 
-                    sb.append(Strings.toString(XContentType.JSON, af) + System.lineSeparator());
+                    sb.append(Strings.toString(af) + System.lineSeparator());
 
                     LogManager.getLogger("debuglogger").error(sb.toString());
 
@@ -223,7 +222,7 @@ public boolean invoke(String action, ActionRequest request, final ActionListener
                     searchRequest.requestCache(Boolean.FALSE);
                 } else {
                 	LogManager.getLogger("debuglogger").error("Shard requestcache enabled for "
-                            + (searchRequest.source() == null ? "<NULL>" : Strings.toString(XContentType.JSON, searchRequest.source())));
+                            + (searchRequest.source() == null ? "<NULL>" : Strings.toString(searchRequest.source())));
                 }
 
             } else {
diff --git a/src/main/java/org/opensearch/security/tools/SecurityAdmin.java b/src/main/java/org/opensearch/security/tools/SecurityAdmin.java
@@ -999,7 +999,7 @@ protected static void generateDiagnoseTrace(final RestHighLevelClient restHighLe
         try {
             sb.append("ClusterHealthRequest:"+System.lineSeparator());
 			ClusterHealthResponse nir = restHighLevelClient.cluster().health(new ClusterHealthRequest(), RequestOptions.DEFAULT);
-			sb.append(Strings.toString(XContentType.JSON, nir, true, true));
+			sb.append(Strings.toString(nir, true, true));
         } catch (Exception e1) {
             sb.append(ExceptionsHelper.stackTrace(e1));
         }
diff --git a/src/test/java/org/opensearch/security/ConfigTests.java b/src/test/java/org/opensearch/security/ConfigTests.java
@@ -28,7 +28,6 @@
 
 import org.opensearch.common.Strings;
 import org.opensearch.common.collect.Tuple;
-import org.opensearch.common.xcontent.XContentType;
 import org.opensearch.security.securityconf.Migration;
 import org.opensearch.security.securityconf.impl.CType;
 import org.opensearch.security.securityconf.impl.SecurityDynamicConfiguration;
@@ -60,18 +59,18 @@ public void testMigrate() throws Exception {
         Tuple<SecurityDynamicConfiguration<RoleV7>, SecurityDynamicConfiguration<TenantV7>> rolesResult = Migration.migrateRoles((SecurityDynamicConfiguration<RoleV6>)load("./legacy/securityconfig_v6/roles.yml", CType.ROLES),
                 (SecurityDynamicConfiguration<RoleMappingsV6>)load("./legacy/securityconfig_v6/roles_mapping.yml", CType.ROLESMAPPING));
         
-        System.out.println(Strings.toString(XContentType.JSON, rolesResult.v2(), true, false));
-        System.out.println(Strings.toString(XContentType.JSON, rolesResult.v1(), true, false));
+        System.out.println(Strings.toString(rolesResult.v2(), true, false));
+        System.out.println(Strings.toString(rolesResult.v1(), true, false));
         
         
         SecurityDynamicConfiguration<ActionGroupsV7> actionGroupsResult = Migration.migrateActionGroups((SecurityDynamicConfiguration<ActionGroupsV6>)load("./legacy/securityconfig_v6/action_groups.yml", CType.ACTIONGROUPS));
-        System.out.println(Strings.toString(XContentType.JSON, actionGroupsResult, true, false));
+        System.out.println(Strings.toString(actionGroupsResult, true, false));
         SecurityDynamicConfiguration<ConfigV7> configResult =Migration.migrateConfig((SecurityDynamicConfiguration<ConfigV6>)load("./legacy/securityconfig_v6/config.yml", CType.CONFIG));
-        System.out.println(Strings.toString(XContentType.JSON, configResult, true, false));
+        System.out.println(Strings.toString(configResult, true, false));
         SecurityDynamicConfiguration<InternalUserV7> internalUsersResult = Migration.migrateInternalUsers((SecurityDynamicConfiguration<InternalUserV6>)load("./legacy/securityconfig_v6/internal_users.yml", CType.INTERNALUSERS));
-        System.out.println(Strings.toString(XContentType.JSON, internalUsersResult, true, false));
+        System.out.println(Strings.toString(internalUsersResult, true, false));
         SecurityDynamicConfiguration<RoleMappingsV7> rolemappingsResult = Migration.migrateRoleMappings((SecurityDynamicConfiguration<RoleMappingsV6>)load("./legacy/securityconfig_v6/roles_mapping.yml", CType.ROLESMAPPING));
-        System.out.println(Strings.toString(XContentType.JSON, rolemappingsResult, true, false));
+        System.out.println(Strings.toString(rolemappingsResult, true, false));
     }
     
     @Test
@@ -114,7 +113,7 @@ private void check(String file, CType cType) throws Exception {
         //Assert.assertTrue(dc.getCEntries().size() > 0);
         String jsonSerialize = DefaultObjectMapper.objectMapper.writeValueAsString(dc);
         SecurityDynamicConfiguration<?> conf = SecurityDynamicConfiguration.fromJson(jsonSerialize, cType, configVersion, 0, 0);
-        SecurityDynamicConfiguration.fromJson(Strings.toString(XContentType.JSON, conf), cType, configVersion, 0, 0);
+        SecurityDynamicConfiguration.fromJson(Strings.toString(conf), cType, configVersion, 0, 0);
         
     }
     
diff --git a/src/test/java/org/opensearch/security/dlic/dlsfls/DlsTest.java b/src/test/java/org/opensearch/security/dlic/dlsfls/DlsTest.java
@@ -42,7 +42,7 @@ protected void populateData(Client tc) {
             e.printStackTrace();
         }
         System.out.println("q");
-        System.out.println(Strings.toString(XContentType.JSON, tc.search(new SearchRequest().indices(".opendistro_security")).actionGet()));
+        System.out.println(Strings.toString(tc.search(new SearchRequest().indices(".opendistro_security")).actionGet()));
         tc.search(new SearchRequest().indices("deals")).actionGet();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@`
`34`	`34`	`import org.opensearch.common.io.stream.StreamOutput;`
`35`	`35`	`import org.opensearch.common.xcontent.ToXContent;`
`36`	`36`	`import org.opensearch.common.xcontent.XContentBuilder;`
`37`		`-import org.opensearch.common.xcontent.XContentType;`
`38`	`37`
`39`	`38`	`public class WhoAmIResponse extends ActionResponse implements ToXContent {`
`40`	`39`
`@@ -106,6 +105,6 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws`
`106`	`105`
`107`	`106`	`@Override`
`108`	`107`	`public String toString() {`
`109`		`- return Strings.toString(XContentType.JSON,this, true, true);`
	`108`	`+ return Strings.toString(this, true, true);`
`110`	`109`	`}`
`111`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -999,7 +999,7 @@ protected static void generateDiagnoseTrace(final RestHighLevelClient restHighLe`
`999`	`999`	`try {`
`1000`	`1000`	`sb.append("ClusterHealthRequest:"+System.lineSeparator());`
`1001`	`1001`	`ClusterHealthResponse nir = restHighLevelClient.cluster().health(new ClusterHealthRequest(), RequestOptions.DEFAULT);`
`1002`		`- sb.append(Strings.toString(XContentType.JSON, nir, true, true));`
	`1002`	`+ sb.append(Strings.toString(nir, true, true));`
`1003`	`1003`	`} catch (Exception e1) {`
`1004`	`1004`	`sb.append(ExceptionsHelper.stackTrace(e1));`
`1005`	`1005`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ protected void populateData(Client tc) {`
`42`	`42`	`e.printStackTrace();`
`43`	`43`	`}`
`44`	`44`	`System.out.println("q");`
`45`		`- System.out.println(Strings.toString(XContentType.JSON, tc.search(new SearchRequest().indices(".opendistro_security")).actionGet()));`
	`45`	`+ System.out.println(Strings.toString(tc.search(new SearchRequest().indices(".opendistro_security")).actionGet()));`
`46`	`46`	`tc.search(new SearchRequest().indices("deals")).actionGet();`
`47`	`47`	`}`
`48`	`48`