Use non-hermetic maven build (#2153)

* WIP: Use non-hermetic maven build

* Remove deps build steps

Author: dsimansk

.tekton/docker-java-build.yaml

@@ -116,83 +116,6 @@ spec:
     name: CHAINS-GIT_COMMIT
     value: $(tasks.clone-repository.results.commit)
   tasks:
-  - matrix:
-      params:
-      - name: PLATFORM
-        value:
-        - $(params.build-platforms)
-    name: build-images-deps
-    params:
-    - name: IMAGE
-      value: $(params.output-image)-deps
-    - name: DOCKERFILE
-      value: $(params.dockerfile).deps
-    - name: CONTEXT
-      value: $(params.path-context)
-    - name: HERMETIC
-      value: "false"
-    - name: PREFETCH_INPUT
-      value: $(params.prefetch-input)
-    - name: IMAGE_EXPIRES_AFTER
-      value: $(params.image-expires-after)
-    - name: COMMIT_SHA
-      value: $(tasks.clone-repository.results.commit)
-    - name: BUILD_ARGS
-      value:
-      - $(params.build-args[*])
-    - name: BUILD_ARGS_FILE
-      value: $(params.build-args-file)
-    - name: SOURCE_ARTIFACT
-      value: $(tasks.prefetch-dependencies.results.SOURCE_ARTIFACT)
-    - name: CACHI2_ARTIFACT
-      value: $(tasks.prefetch-dependencies.results.CACHI2_ARTIFACT)
-    - name: IMAGE_APPEND_PLATFORM
-      value: "true"
-    runAfter:
-    - prefetch-dependencies
-    taskRef:
-      params:
-      - name: name
-        value: buildah-remote-oci-ta
-      - name: bundle
-        value: quay.io/konflux-ci/tekton-catalog/task-buildah-remote-oci-ta:0.6@sha256:3832edaec1aae546c225c86ada53611e42717c784e2068e0536831a99cb1922d
-      - name: kind
-        value: task
-      resolver: bundles
-    when:
-    - input: $(tasks.init.results.build)
-      operator: in
-      values:
-      - "true"
-  - name: build-image-index-deps
-    params:
-    - name: IMAGE
-      value: $(params.output-image)-deps
-    - name: COMMIT_SHA
-      value: $(tasks.clone-repository.results.commit)
-    - name: IMAGE_EXPIRES_AFTER
-      value: $(params.image-expires-after)
-    - name: ALWAYS_BUILD_INDEX
-      value: $(params.build-image-index)
-    - name: IMAGES
-      value:
-      - $(tasks.build-images-deps.results.IMAGE_REF[*])
-    runAfter:
-    - build-images-deps
-    taskRef:
-      params:
-      - name: name
-        value: build-image-index
-      - name: bundle
-        value: quay.io/konflux-ci/tekton-catalog/task-build-image-index:0.1@sha256:d94cad7f41be61074dd21c7dff26dab9217c3435a16f62813c1cb8382dd9aae6
-      - name: kind
-        value: task
-      resolver: bundles
-    when:
-    - input: $(tasks.init.results.build)
-      operator: in
-      values:
-      - "true"
   - matrix:
       params:
       - name: PLATFORM
@@ -202,7 +125,6 @@ spec:
     params:
     - name: BUILD_ARGS
       value:
-      - DEPS_IMAGE=$(tasks.build-image-index-deps.results.IMAGE_URL)@$(tasks.build-image-index-deps.results.IMAGE_DIGEST)
       - $(params.build-args[*])
     - name: IMAGE
       value: $(params.output-image)
@@ -233,7 +155,7 @@ spec:
     - name: IMAGE_APPEND_PLATFORM
       value: "true"
     runAfter:
-    - build-image-index-deps
+    - prefetch-dependencies
     taskRef:
       params:
       - name: name

.tekton/kn-ekb-dispatcher-117-pull-request.yaml

@@ -32,7 +32,7 @@ spec:
     - name: git-url
       value: '{{source_url}}'
     - name: hermetic
-      value: "true"
+      value: "false"
     - name: image-expires-after
       value: 5d
     - name: output-image

.tekton/kn-ekb-dispatcher-117-push.yaml

@@ -31,7 +31,7 @@ spec:
     - name: git-url
       value: '{{source_url}}'
     - name: hermetic
-      value: "true"
+      value: "false"
     - name: output-image
       value: quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-137/kn-ekb-dispatcher:{{revision}}
     - name: revision

.tekton/kn-ekb-receiver-117-pull-request.yaml

@@ -32,7 +32,7 @@ spec:
     - name: git-url
       value: '{{source_url}}'
     - name: hermetic
-      value: "true"
+      value: "false"
     - name: image-expires-after
       value: 5d
     - name: output-image

.tekton/kn-ekb-receiver-117-push.yaml

@@ -31,7 +31,7 @@ spec:
     - name: git-url
       value: '{{source_url}}'
     - name: hermetic
-      value: "true"
+      value: "false"
     - name: output-image
       value: quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-137/kn-ekb-receiver:{{revision}}
     - name: revision

openshift/ci-operator/static-images/dispatcher/hermetic/Dockerfile

@@ -16,21 +16,16 @@
 
 ARG JAVA_BUILDER=registry.access.redhat.com/ubi9/openjdk-21
 ARG JAVA_RUNTIME=registry.access.redhat.com/ubi9/openjdk-21-runtime
-ARG DEPS_IMAGE
-
-FROM $DEPS_IMAGE AS deps
 
 FROM $JAVA_BUILDER AS builder
 
 USER root
 
 WORKDIR /build
 
-COPY --from=deps /third_party/maven/ /third_party/maven/
-
 COPY /data-plane .
 
-RUN mvn -Dmaven.repo.local=/third_party/maven --offline package -pl=dispatcher-loom -Drelease -am -DskipTests --no-transfer-progress
+RUN mvn package -pl=dispatcher-loom -Drelease -am -DskipTests --no-transfer-progress
 
 RUN mkdir /app && cp /build/dispatcher-loom/target/dispatcher-loom-1.0-SNAPSHOT.jar /app/app.jar
 
@@ -50,6 +45,7 @@ LABEL \
       io.k8s.display-name="Red Hat OpenShift Serverless 1 Eventing Kafka Broker Dispatcher" \
       io.k8s.description="Red Hat OpenShift Serverless Eventing Kafka Broker Dispatcher" \
       io.openshift.tags=dispatcher \
+      vendor="Red Hat, Inc." \
       cpe="cpe:/a:redhat:openshift_serverless:1.37::el9"
 
 COPY --from=builder /app /app

openshift/ci-operator/static-images/receiver/hermetic/Dockerfile

@@ -16,21 +16,16 @@
 
 ARG JAVA_BUILDER=registry.access.redhat.com/ubi9/openjdk-21
 ARG JAVA_RUNTIME=registry.access.redhat.com/ubi9/openjdk-21-runtime
-ARG DEPS_IMAGE
-
-FROM $DEPS_IMAGE AS deps
 
 FROM $JAVA_BUILDER AS builder
 
 USER root
 
 WORKDIR /build
 
-COPY --from=deps /third_party/maven/ /third_party/maven/
-
 COPY /data-plane .
 
-RUN mvn -Dmaven.repo.local=/third_party/maven --offline package -pl=receiver-loom -Drelease -am -DskipTests --no-transfer-progress
+RUN mvn package -pl=receiver-loom -Drelease -am -DskipTests --no-transfer-progress
 
 RUN mkdir /app && cp /build/receiver-loom/target/receiver-loom-1.0-SNAPSHOT.jar /app/app.jar
 
@@ -50,6 +45,7 @@ LABEL \
       io.k8s.display-name="Red Hat OpenShift Serverless 1 Eventing Kafka Broker Receiver" \
       io.k8s.description="Red Hat OpenShift Serverless Eventing Kafka Broker Receiver" \
       io.openshift.tags=receiver \
+      vendor="Red Hat, Inc." \
       cpe="cpe:/a:redhat:openshift_serverless:1.37::el9"
 
 COPY --from=builder /app /app