-
Notifications
You must be signed in to change notification settings - Fork 84
Mongo application CSI DOWN FOR MAINTENANCE #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kaovilai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[FAIL] Backup and restore tests Backup and restore applications [It] Mongo application DATAMOVER |
|
/retest |
c0e61fd
|
New changes are detected. LGTM label has been removed. |
|
/retest |
1 similar comment
|
/retest |
WalkthroughThree Mongo-related test entries are disabled via commenting and marked "DOWN FOR MAINTENANCE" across two test suite files. The modifications do not alter test logic or scaffolding; remaining tests continue unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/e2e/backup_restore_suite_test.go (1)
411-422: Consider tracking this maintenance work with a GitHub issue.The test is appropriately disabled with a clear marker. However, to ensure these tests are re-enabled once the underlying issues are resolved, consider:
- Creating a GitHub issue to track the Mongo CSI test failures
- Referencing the issue number in the comment (e.g.,
// DOWN FOR MAINTENANCE - See issue #XXXX)- Setting a timeline or milestone for re-enabling the tests
Do you want me to help draft a GitHub issue description to track the re-enablement of these Mongo-related tests?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (2)
tests/e2e/backup_restore_cli_suite_test.go(3 hunks)tests/e2e/backup_restore_suite_test.go(3 hunks)
🔇 Additional comments (5)
tests/e2e/backup_restore_suite_test.go (2)
445-456: Consistent with the maintenance approach for Mongo tests.This DATAMOVER test is appropriately disabled alongside the CSI test. Ensure all disabled Mongo tests are tracked together in a single GitHub issue for easier management and re-enablement.
468-480: Third Mongo test appropriately disabled.This BlockDevice DATAMOVER test completes the set of disabled Mongo tests. All three disabled tests (CSI, DATAMOVER, BlockDevice DATAMOVER) should be tracked in a single GitHub issue for coordinated re-enablement.
tests/e2e/backup_restore_cli_suite_test.go (3)
273-284: CLI tests consistently disabled with non-CLI tests.This mirrors the Mongo CSI test disabled in
backup_restore_suite_test.go. Ensure both the CLI and non-CLI Mongo tests are tracked together in the same GitHub issue for coordinated re-enablement.
307-318: DATAMOVER CLI test appropriately disabled.This mirrors the DATAMOVER test disabled in the non-CLI suite. The consistency across both test files is good.
330-342: BlockDevice DATAMOVER CLI test appropriately disabled.This completes the set of disabled Mongo CLI tests, maintaining consistency with the non-CLI test suite. All six disabled tests (3 non-CLI + 3 CLI) should be tracked together.
|
/retest |
|
@mpryc known failures we can use PEntry instead of Entry which is easier one line change. |
|
also just merged crd update, expect FSB backups to work now. /retest |
|
/retest ai-retester: The The OADP e2e tests failed because the The e2e test |
|
/retest ai-retester: The e2e tests failed because the "MySQL application KOPIA" test timed out after 540 seconds, and the The |
|
/retest ai-retester: The The The e2e tests failed specifically during the "Mongo application Native-Snapshots via CLI" test, because the todolist pod never reached a successful state, and after many retries it eventually timed out waiting for the Pod. It exited with code 2. |
|
/retest ai-retester: The The "MySQL application two Vol CSI" e2e test failed because it couldn't connect to the todolist service after the restore. The container The e2e "Mongo application Native-Snapshots via CLI" test timed out and failed because the todolist pod never reached a successful state during the test. |
|
/retest ai-retester: The e2e tests failed, specifically the "MySQL application two Vol CSI" test in the The |
|
/retest ai-retester: The e2e tests failed. Specifically, the "MySQL application two Vol CSI" test failed because the restore process encountered an error when accessing the application's endpoint via the route and subsequently timed out trying to communicate with service directly. The container exited with code 7 during this phase. The e2e test |
|
/retest ai-retester: The e2e test failed because the "Mongo application Native-Snapshots" test timed out after 540 seconds while waiting for a Pod to succeed. The container "test" in pod "e2e-test-aws-e2e" also exited with an error code of 2 indicating a test failure. The only test that hit a hard failure was the “MySQL application – two‑volume CSI via CLI” test. A few clues from the logs explain why the pod never reached a running state:
In short, the test failed because the restore step created a pod that could not finish initialization: the CSI snapshots were not yet fully available, the old DeploymentConfig style was still used (causing additional delays), and the init‑container finished too late, so the main container never started before the test timed out. Fixing the volume claim handling or switching the pod deployment to a modern |
|
/retest ai-retester: The e2e tests failed because the "test" container in pod "e2e-test-cli-aws-e2e" exited with a non-zero exit code (2), indicating an error during the OADP e2e tests. More specifically, the test "MySQL application KOPIA via CLI" timed out after 540 seconds and the pod "todolist-1-md9jw" was stuck in The automated test |
|
/retest ai-retester: The e2e tests failed because the "MySQL application two Vol CSI" test failed. Specifically, the restore process failed in that test with a "PodInitializing" error and network connectivity issues. The test |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest ai-retester: The The |
|
/retest ai-retester: The e2e test failed because the The e2e test failed. Specifically, the "MySQL application two Vol CSI" test failed because the application endpoint was not accessible after the restore. The todolist container might not be starting properly. Also there are podInitializing errors and multi-attach errors observed from the app namespace events. |
|
/retest ai-retester: The "Mongo application Native-Snapshots" e2e test timed out and failed after 1 hour, 1 minute, and 11 seconds. The test pod got stuck in PodInitializing. The e2e test |
|
@weshayutin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
no need: #2013 |
Why the changes were made
Too many test failures w/ mongo csi
How to test the changes made