DID WebVH is hardcoded as a resolver in the core package overriding all the credo DID resolvers

[timbl-ont]

Description of problem

DID resolvers no longer work in themed wallets i.e. DID:JWK unless explicitly added.

Expected behaviour

If the themed app does not include any resolvers then the default credo ones should be used

@PatStLouis I think the following should be configured in the themed wallets (i.e. Bifold sample app) and not the core.

https://github.com/openwallet-foundation/bifold-wallet/blob/main/packages/core/src/utils/agent.ts#L111

[timbl-ont]

@MosCD3 Will submit a PR to add the missing DID resolvers for now.

[PatStLouis]

@timbl-ont Hi Tim, this is not a behavior I envisioned by making this change. Are the default DID methods from credo only the ones added in the PR or do they include all DID methods from the credo packages?

I was expecting bifold to already be able to resolve webvh anoncreds when updating to the latest credo version but this step seemed also required.

[timbl-ont]

@PatStLouis I am not sure why webvh resolver was not available just from the credo update. Previously we did not have to explicitly define resolvers in Bifold from what I can see. @MosCD3 has submitted a PR #1684 that was merged to add back resolvers. There are still some missing including did:web. I am concerned that there might be others as it was a quick fix and a bit rushed.

This needs a deeper dive.

[PatStLouis]

ok, I'll have a closer look at what default resolvers credo is including, and try to understand why webvh wasn't included in those.

[timbl-ont]

It may also be related to changes with credo 0.5.17?

[PatStLouis]

It seems like webvh is not included in the default resolvers, only what's in credo/core:
https://github.com/openwallet-foundation/credo-ts/tree/main/packages/core/src/modules/dids/methods

Looking at the bifold agent, its already importing a few modules. Since the credo core only have 4 did methods, and they have been added, I would suggest to keep the didsModule and have supported methods defined there.

[jleach]

@PatStLouis Do we still have work to do on this one?

[PatStLouis]

@jleach @timbl-ont are we happy with the current state? There are 4 core resolvers in credo (web, kwy, jwk, sov). In order to add webvh, we needed to declaratively register the 4 core resolvers + the webvh resolver.

I'm proposing to leave it like this and close the issue.

[timbl-ont]

We just need to consider that any new did method resolver in credo will need to be explicitly added in Bifold and track the work. Perhaps it should be documented?

[PatStLouis]

I added documentation here #1719, please review