Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 13, 2025

Description of the change:

github.com/golang/mock has been archived since June 2023.

Update to the maintained library.

Updated yq in bingo to be a version that uses go.uber.org/mock The latest available helm still uses github.com/golang/mock The latest 1.x of golangci-lint still use github.com/golang/mock

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

github.com/golang/mock has been archived since June 2023.

Update to the maintained library.

Updated `yq` in bingo to be a version that uses go.uber.org/mock
The latest available `helm` still uses github.com/golang/mock
The latest 1.x of golangci-lint still use github.com/golang/mock

Signed-off-by: Todd Short <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant