[GR-16559] Script install_r_native_image supports --verbose flag.

PullRequest: fastr/2058

Author: steve-s

ci.hocon

@@ -8,7 +8,7 @@ include "ci_common/common.hocon"
 # The standard set of gate builds. N.B. the style/builtin checks are only run on Linux as they are not OS-dependent.
 
 # in case you do not want to enforce a specific overlay commit, comment:
-overlay = "9fd1ed7dac318a520ffe30b28bde900553950658"
+overlay = "6f60c2cc12f2c909405d0b0668a1c78f9796b3d8"
 builds = [
   ${gateTestLinux}            {capabilities : [linux, amd64, fast],  targets : [gate], name: "gate-test-linux-amd64"}
   ${gateTestNoDSLCacheLinux}  {capabilities : [linux, amd64, fast],  targets : [gate], name: "gate-test-linux-amd64-no-dsl-cache"}

ci_common/common.hocon

@@ -56,7 +56,7 @@ logfiles : [
 environmentLinux: {
   environment : {
     PKG_INCLUDE_FLAGS_OVERRIDE : "-I/cm/shared/apps/zlib/1.2.11/include -I/cm/shared/apps/bzip2/1.0.6/include -I/cm/shared/apps/xz/5.2.2/include -I/cm/shared/apps/pcre/8.42/include -I/cm/shared/apps/curl/7.50.1/include"
-    PKG_LDFLAGS_OVERRIDE : "-L/cm/shared/apps/zlib/1.2.11/lib -L/cm/shared/apps/bzip2/1.0.6/lib -L/cm/shared/apps/xz/5.2.2/lib -L/cm/shared/apps/pcre/8.42/lib -L/cm/shared/apps/curl/7.50.1/lib -L/cm/shared/apps/gcc/4.9.1/lib64"
+    PKG_LDFLAGS_OVERRIDE : "-L/cm/shared/apps/zlib/1.2.11/lib -L/cm/shared/apps/bzip2/1.0.6/lib -L/cm/shared/apps/xz/5.2.2/lib -L/cm/shared/apps/pcre/8.42/lib -L/cm/shared/apps/curl/7.50.1/lib -L/cm/shared/apps/gcc/4.9.2/lib64"
     TZDIR: "/usr/share/zoneinfo"
   }
 }
@@ -78,7 +78,8 @@ packagesLinux : {
     "pip:pylint" : "==1.1.0"
     "pip:ninja_syntax" : "==1.7.2"
     make : ">=3.83"
-    gcc-build-essentials : "==4.9.1" # TODO: upgrade to 4.9.2
+    gcc-build-essentials : "==4.9.2"
+    binutils: ">=2.30"
     pcre : "==8.42"
     zlib : "==1.2.11"
     # these are needed to build GNU-R

com.oracle.truffle.r.native/run/install_r_native_image

@@ -40,19 +40,29 @@ fastr_home="$(dirname "$source")/.."
 
 silent=0
 uninstall=0
+verbose=0
 for arg in "$@"; do
     if [[ $arg == "--silent" ]]; then
         silent=1
+    elif [[ $arg == "--verbose" ]]; then
+        verbose=1
     elif [[ $arg == "uninstall" ]]; then
         uninstall=1
     elif [[ $arg == "--help" ]]; then
         echo "Usage: install_r_native_image [uninstall] [--silent]"
         echo "When 'uninstall' argument is not present: builds and installs native image of the R runtime."
         echo "When 'uninstall' argument is present: uninstalls previously installed native image of the R runtime."
         echo "Use the --silent option to turn off the confirmation when installing."
+        echo "Use the --verbose option to turn on detailed logging."
     fi
 done
 
+function log {
+    if [[ $verbose -eq 1 ]]; then
+        echo $@
+    fi
+}
+
 if [[ $uninstall -eq 1 ]]; then
     echo "Uninstalling native image of R runtime..."
     mv "$fastr_home/bin/exec_R.backup" "$fastr_home/bin/exec/R"
@@ -73,6 +83,7 @@ if [[ $silent -eq 0 ]]; then
     fi
 fi
 
+log "Changing directory to: $fastr_home/bin"
 cd "$fastr_home/bin"
 
 fastr_launcher_ni_args=(
@@ -89,10 +100,18 @@ fastr_launcher_ni_args=(
     -Dorg.graalvm.launcher.classpath=jre/lib/graalvm/launcher-common.jar:jre/languages/R/fastr-launcher.jar
     -H:Class=com.oracle.truffle.r.launcher.RMain
 )
+if [[ $verbose -eq 1 ]]; then
+  fastr_launcher_ni_args+=('--verbose')
+fi
 
+log "Running: ../../../../bin/native-image" "${fastr_launcher_ni_args[@]}" -H:Name=RMain
 ../../../../bin/native-image "${fastr_launcher_ni_args[@]}" -H:Name=RMain
+
+log "Creating backup of the R and Rscript launchers"
 cp "exec/R" "exec_R.backup"
 cp "Rscript" "Rscript.backup"
+
+log "Patching the R and Rscript launchers to dispatch to the generated native image"
 sed -e '/^## REMOVE FOR NATIVE IMAGE: BEGIN/,/^## REMOVE FOR NATIVE IMAGE: END/d;' "exec_R.backup" | \
     sed -e 's|^exec "$JAVA_HOME/bin/java" .*|exec "$R_HOME/bin/RMain" R ${FASTR_INTERNAL_ARGS[@]} "$@"|' > "exec/R"
 sed -e '/^## REMOVE FOR NATIVE IMAGE: BEGIN/,/^## REMOVE FOR NATIVE IMAGE: END/d;' "Rscript.backup" | \