[GR-14716] Pkgtest: Fix default test file status.

PullRequest: fastr/1981

Author: fangerer

com.oracle.truffle.r.test.packages/pkgtest/__init__.py

@@ -317,7 +317,15 @@ class TestFileStatus:
     def __init__(self, status, abspath):
         self.status = status
         self.abspath = abspath
-        self.report = 0, 1, 0
+        if status == "OK":
+            # At this point, status == "OK" means that we had no '.fail' output file and we will investigate the single
+            # test cases. So, initially we claim the test was skipped because if GnuR failed on the test, we state that
+            # we skipped it.
+            self.report = 0, 1, 0
+        elif status == "FAILED":
+            self.report = 0, 0, 1
+        else:
+            raise ValueError('Invalid test file status: %s (allowed: "OK", "FAILED")' % status)
 
 
 class TestStatus:

com.oracle.truffle.r.test.packages/r/install.cache.R

@@ -719,11 +719,11 @@ pkg.cache.full.install <- function(install.candidate.names, contriburl, lib.inst
 
     # override packages need to be installed differently
     if (length(pkgs.in.overrides) > 0) {
-        install.fastr.packages(as.character(pkgs.in.overrides), lib=lib.install, INSTALL_opts="--install-tests")
+        install.fastr.packages(as.character(pkgs.in.overrides), lib=lib.install, INSTALL_opts="--install-tests --no-clean-on-error")
     }
 
     if (length(pkgs.not.in.overrides) > 0) {
-        install.packages(as.character(pkgs.not.in.overrides), contriburl=contriburl, type="source", lib=lib.install, INSTALL_opts="--install-tests")
+        install.packages(as.character(pkgs.not.in.overrides), contriburl=contriburl, type="source", lib=lib.install, INSTALL_opts="--install-tests --no-clean-on-error")
     }
 }