Catch more log files from pkgtest in CI + style fixes

Author: steve-s

ci_common/common.hocon

@@ -101,7 +101,8 @@ common : ${java8Downloads} {
   logs: ${logfiles}
   catch_files : [
     "Graal diagnostic output saved in (?P<filename>.+\.zip)",
-    "output mismatch file: (?P<filename>.+\.Rout)"
+    "output mismatch file: (?P<filename>.+\.Rout)",
+    "test had .fail outputs: \['(?P<filename>.+)'\]"
   ]
   timelimit : "1:00:00"
   environment : {

com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Attr.java

@@ -133,7 +133,7 @@ protected abstract static class PartialSearchCache extends Node {
         public abstract Object execute(DynamicObject attributes, String name);
 
         @Specialization(guards = {"attrs.getShape() == cachedShape", "name.equals(cachedName)"}, limit = "getCacheSize(8)")
-        protected Object doCached(DynamicObject attrs, String name,
+        protected Object doCached(@SuppressWarnings("unused") DynamicObject attrs, @SuppressWarnings("unused") String name,
                         @SuppressWarnings("unused") @Cached("attrs.getShape()") Shape cachedShape,
                         @SuppressWarnings("unused") @Cached("name") String cachedName,
                         @Cached("iterAttrAccess.execute(attrs,name)") Object result) {

com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/access/variables/LocalReadVariableNode.java

@@ -28,10 +28,8 @@
 import com.oracle.truffle.api.frame.Frame;
 import com.oracle.truffle.api.frame.FrameDescriptor;
 import com.oracle.truffle.api.frame.FrameSlot;
-import com.oracle.truffle.api.frame.FrameSlotKind;
 import com.oracle.truffle.api.frame.VirtualFrame;
 import com.oracle.truffle.api.nodes.InvalidAssumptionException;
-import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.nodes.UnexpectedResultException;
 import com.oracle.truffle.api.profiles.ConditionProfile;
 import com.oracle.truffle.api.profiles.ValueProfile;

com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/ForEachAttributeNode.java

@@ -57,7 +57,7 @@ public static ForEachAttributeNode create(AttributeAction action) {
      * should be set by this function.
      */
     public abstract static class AttributeAction extends Node {
-        public void init(Context context) {
+        public void init(@SuppressWarnings("unused") Context context) {
             // nop
         }
 

com.oracle.truffle.r.test.packages/pkgtest/__init__.py

@@ -494,7 +494,7 @@ def _gnur_install_test(forwarded_args, pkgs, gnur_libinstall, gnur_install_tmp):
 def _set_test_status(fastr_test_info):
     def _failed_outputs(outputs):
         '''
-        return True iff outputs has any .fail files
+        return False iff outputs has no .fail files
         '''
         for _, testfile_status in outputs.iteritems():
             if testfile_status.status == "FAILED":
@@ -518,7 +518,7 @@ def _failed_outputs(outputs):
             # What this likely means is that some native package is not
             # installed on the system so GNUR can't run the tests.
             # Ideally this never happens.
-            logging.info("{0}: GnuR test had .fail outputs: {1}".format(pkg, str(gnur_failed_outputs)))
+            logging.info("{0}: GnuR test had .fail outputs: {1}".format(pkg, str([s + '.fail' for s in gnur_failed_outputs])))
 
         fastr_failed_outputs = _failed_outputs(fastr_outputs)
         if fastr_failed_outputs: