Do not log internal errors by default

Author: steve-s

ci_common/common.hocon

@@ -88,6 +88,7 @@ common : ${java8Downloads} ${packagesLinux}  {
   environment : {
 	PKG_TEST_ENV_miniUI : "LC_ALL=C"
 	PKG_TEST_ENV_compare : "LC_ALL=C"
+	FASTR_OPTION_PrintErrorStacktracesToFile: "true"
   }
 }
 

com.oracle.truffle.r.engine/src/com/oracle/truffle/r/engine/REngine.java

@@ -653,7 +653,10 @@ public RNode getBody() {
 
     @TruffleBoundary
     private static boolean checkResult(Object result) {
-        return RAbstractVector.verify((RAbstractVector) result);
+        if (result instanceof RAbstractVector) {
+            return RAbstractVector.verify((RAbstractVector) result);
+        }
+        return true;
     }
 
     @Override

com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/FastROptions.java

@@ -38,7 +38,7 @@
  */
 public enum FastROptions {
     PrintErrorStacktraces("Prints Java and R stack traces for all errors", false),
-    PrintErrorStacktracesToFile("Dumps Java and R stack traces to 'fastr_errors.log' for all errors", true),
+    PrintErrorStacktracesToFile("Dumps Java and R stack traces to 'fastr_errors.log' for all errors", false),
     // TODO: this should be logging category
     Debug("Debug=name1,name2,...; Turn on debugging output for 'name1', 'name2', etc.", null, true),
     TraceCalls("Trace all R function calls", false),

com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/RInternalError.java

@@ -213,7 +213,8 @@ private static void reportError(String errMsg, Throwable throwable, int contextI
                         RSuicide.rSuicide("FastR internal error");
                     }
                 } else {
-                    message += ".";
+                    message += ". You can rerun FastR with --jvm.DR:+" + FastROptions.PrintErrorStacktracesToFile.name() +
+                                    " to turn on internal errors logging. Please attach the log file to the issue if possible.";
                 }
                 if (!FastROptions.PrintErrorStacktraces.getBooleanValue() && !FastROptions.PrintErrorStacktracesToFile.getBooleanValue()) {
                     System.err.println(message);