Skip to content

Commit e791c2e

Browse files
Miloslav Metelkaansalond
authored andcommitted
Resolved review notes.
(cherry picked from commit 6574e67)
1 parent a5e9d73 commit e791c2e

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

com.oracle.truffle.r.ffi.impl/src/com/oracle/truffle/r/ffi/impl/llvm/TruffleLLVM_DLL.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,9 @@ private static CallTarget parseBinary(String libName, LLVM_IR.Binary ir) {
378378
long start = System.nanoTime();
379379
RContext context = RContext.getInstance();
380380
long nanos = 1000 * 1000 * 1000;
381-
Source source = Source.newBuilder("", ir.base64, ir.name).mimeType("application/x-llvm-ir-bitcode-base64").build();
381+
String mimeType = "application/x-llvm-ir-bitcode-base64";
382+
String language = Source.findLanguage(mimeType);
383+
Source source = Source.newBuilder(language, ir.base64, ir.name).mimeType(mimeType).build();
382384
CallTarget result = context.getEnv().parse(source);
383385
if (System.getenv("LLVM_PARSE_TIME") != null) {
384386
long end = System.nanoTime();

com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/fastr/FastRInterop.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,12 +211,13 @@ protected CallTarget parseFile(String path, String languageIdArg) {
211211

212212
File file = new File(path);
213213
try {
214+
Env env = RContext.getInstance().getEnv();
215+
TruffleFile tFile = env.getTruffleFile(file.getAbsolutePath());
214216
String languageId = languageIdArg;
215-
if (languageId == null) { // null languageId not allowed in newBuilder()
216-
languageId = RRuntime.R_LANGUAGE_ID;
217+
if (languageId == null) {
218+
languageId = Source.findLanguage(tFile);
217219
}
218-
Env env = RContext.getInstance().getEnv();
219-
SourceBuilder sourceBuilder = Source.newBuilder(languageId, env.getTruffleFile(file.getAbsolutePath())).name(file.getName());
220+
SourceBuilder sourceBuilder = Source.newBuilder(languageId, tFile).name(file.getName());
220221
Source sourceObject = sourceBuilder.build();
221222
return env.parse(sourceObject);
222223
} catch (IOException e) {

0 commit comments

Comments
 (0)