building natmod: linking fails with undefined symbol mp_print_str

[scgbckbone]

• including py/mpprint.h into the module does not fix the issue

LINK build/moduqr.o
LinkError: build/moduqr.o: undefined symbol: mp_print_str
make: *** [../../py/dynruntime.mk:150: build/uqr.native.mpy] Error 1

[scgbckbone]

project:

micropython/
├─ examples/
│ ├─ my_mod/
│ │ ├─ Makefile
│ │ ├─ moduqr.c
│ │ ├─ someothermod.c
│ │ ├─ someothermod.h

[scgbckbone]

Makefile

MPY_DIR = ../..

MOD = uqr

SRC = moduqr.c

ARCH = x64
V= 1
CFLAGS += -Wno-error=return-type \
          -Wno-error=unused-const-variable= \
          -Wno-error=int-conversion \

include $(MPY_DIR)/py/dynruntime.mk

[scgbckbone]

moduqr.c

#ifdef MICROPY_ENABLE_DYNRUNTIME
# include "py/dynruntime.h"
#else
# include "py/runtime.h"
#endif

#include "someothermod.h"
#include <string.h>
#include <stdlib.h>
#include <stdio.h>
#include "py/mpprint.h"


...code...


#include "someothermod.c"

mp_obj_full_type_t mp_type_uqr_t;
mp_map_elem_t uqr_qr_locals_dict_table[4];
STATIC MP_DEFINE_CONST_DICT(uqr_qr_locals_dict, uqr_qr_locals_dict_table);

// mpy_init()
//
// This is the entry point and is called when the module is imported
mp_obj_t mpy_init(mp_obj_fun_bc_t *self, size_t n_args, size_t n_kw, mp_obj_t *args) {
    // This must be first, it sets up the globals dict and other things
    MP_DYNRUNTIME_INIT_ENTRY
    mp_store_global(MP_QSTR___name__, MP_ROM_INT(MP_QSTR_uqr));

    mp_type_uqr_t.base.type = (void*)&mp_type_type;
    mp_type_uqr_t.flags = MP_TYPE_FLAG_NONE;
    mp_type_uqr_t.name = MP_QSTR_RenderedQR;
    MP_OBJ_TYPE_SET_SLOT(&mp_type_uqr_t, make_new, rendered_qr_make_new, 0);
    MP_OBJ_TYPE_SET_SLOT(&mp_type_uqr_t, print, mp_obj_rendered_qr_print, 1);
    uqr_qr_locals_dict_table[0] = (mp_map_elem_t){MP_QSTR___del__, MP_OBJ_FROM_PTR(&rendered_qr_del_obj)};
    uqr_qr_locals_dict_table[1] = (mp_map_elem_t){MP_QSTR_width, MP_OBJ_FROM_PTR(&rendered_qr_width_obj)};
    uqr_qr_locals_dict_table[2] = (mp_map_elem_t){MP_QSTR_get, MP_OBJ_FROM_PTR(&rendered_qr_get_obj)};
    uqr_qr_locals_dict_table[3] = (mp_map_elem_t){MP_QSTR_packed, MP_OBJ_FROM_PTR(&rendered_qr_packed_obj)};
    MP_OBJ_TYPE_SET_SLOT(&mp_type_uqr_t, locals_dict, (void*)&uqr_qr_locals_dict, 2);

    // XXX need to dup info in mp_module_uqr_globals_table above
    // XXX need to set the globals right (BSS vs. data segment issue)
    mp_store_global(MP_QSTR_ECC_LOW, MP_ROM_INT(qrcodegen_Ecc_LOW));
    mp_store_global(MP_QSTR_ECC_MEDIUM, MP_ROM_INT(qrcodegen_Ecc_MEDIUM));
    mp_store_global(MP_QSTR_ECC_QUARTILE, MP_ROM_INT(qrcodegen_Ecc_QUARTILE));
    mp_store_global(MP_QSTR_ECC_HIGH, MP_ROM_INT(qrcodegen_Ecc_HIGH));

    // QR data encoding modes
    mp_store_global(MP_QSTR_Mode_NUMERIC, MP_ROM_INT(qrcodegen_Mode_NUMERIC));
    mp_store_global(MP_QSTR_Mode_ALPHANUMERIC, MP_ROM_INT(qrcodegen_Mode_ALPHANUMERIC));
    mp_store_global(MP_QSTR_Mode_BYTE, MP_ROM_INT(qrcodegen_Mode_BYTE));

    // Version range
    mp_store_global(MP_QSTR_VERSION_MIN, MP_ROM_INT(qrcodegen_VERSION_MIN));
    mp_store_global(MP_QSTR_VERSION_MAX, MP_ROM_INT(qrcodegen_VERSION_MAX));

    // Functions
    mp_store_global(MP_QSTR_make, MP_OBJ_FROM_PTR(&mp_type_uqr_t));

    // This must be last, it restores the globals dict
    MP_DYNRUNTIME_INIT_EXIT
}

[scgbckbone]

console output after make -4 in my_mod directory

$ V=1 make -j4
GEN build/uqr.config.h
CC moduqr.c
In file included from ../../py/mpconfig.h:83,
                 from ../../py/obj.h:31,
                 from ../../py/nativeglue.h:30,
                 from ../../py/dynruntime.h:32,
                 from moduqr.c:4:
moduqr.c: In function ‘mpy_init’:
./build/uqr.config.h:180:25: warning: initialization of ‘void *’ from ‘uint16_t’ {aka ‘const short unsigned int’} makes pointer from integer without a cast [-Wint-conversion]
  180 | #define MP_QSTR___del__ (mp_native_qstr_table[11])
      |                         ^
moduqr.c:401:51: note: in expansion of macro ‘MP_QSTR___del__’
  401 |     uqr_qr_locals_dict_table[0] = (mp_map_elem_t){MP_QSTR___del__, MP_OBJ_FROM_PTR(&rendered_qr_del_obj)};
      |                                                   ^~~~~~~~~~~~~~~
./build/uqr.config.h:180:25: note: (near initialization for ‘(anonymous).key’)
  180 | #define MP_QSTR___del__ (mp_native_qstr_table[11])
      |                         ^
moduqr.c:401:51: note: in expansion of macro ‘MP_QSTR___del__’
  401 |     uqr_qr_locals_dict_table[0] = (mp_map_elem_t){MP_QSTR___del__, MP_OBJ_FROM_PTR(&rendered_qr_del_obj)};
      |                                                   ^~~~~~~~~~~~~~~
./build/uqr.config.h:190:23: warning: initialization of ‘void *’ from ‘uint16_t’ {aka ‘const short unsigned int’} makes pointer from integer without a cast [-Wint-conversion]
  190 | #define MP_QSTR_width (mp_native_qstr_table[21])
      |                       ^
moduqr.c:402:51: note: in expansion of macro ‘MP_QSTR_width’
  402 |     uqr_qr_locals_dict_table[1] = (mp_map_elem_t){MP_QSTR_width, MP_OBJ_FROM_PTR(&rendered_qr_width_obj)};
      |                                                   ^~~~~~~~~~~~~
./build/uqr.config.h:190:23: note: (near initialization for ‘(anonymous).key’)
  190 | #define MP_QSTR_width (mp_native_qstr_table[21])
      |                       ^
moduqr.c:402:51: note: in expansion of macro ‘MP_QSTR_width’
  402 |     uqr_qr_locals_dict_table[1] = (mp_map_elem_t){MP_QSTR_width, MP_OBJ_FROM_PTR(&rendered_qr_width_obj)};
      |                                                   ^~~~~~~~~~~~~
./build/uqr.config.h:90:21: warning: initialization of ‘void *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
   90 | #define MP_QSTR_get (86)
      |                     ^
moduqr.c:403:51: note: in expansion of macro ‘MP_QSTR_get’
  403 |     uqr_qr_locals_dict_table[2] = (mp_map_elem_t){MP_QSTR_get, MP_OBJ_FROM_PTR(&rendered_qr_get_obj)};
      |                                                   ^~~~~~~~~~~
./build/uqr.config.h:90:21: note: (near initialization for ‘(anonymous).key’)
   90 | #define MP_QSTR_get (86)
      |                     ^
moduqr.c:403:51: note: in expansion of macro ‘MP_QSTR_get’
  403 |     uqr_qr_locals_dict_table[2] = (mp_map_elem_t){MP_QSTR_get, MP_OBJ_FROM_PTR(&rendered_qr_get_obj)};
      |                                                   ^~~~~~~~~~~
./build/uqr.config.h:188:24: warning: initialization of ‘void *’ from ‘uint16_t’ {aka ‘const short unsigned int’} makes pointer from integer without a cast [-Wint-conversion]
  188 | #define MP_QSTR_packed (mp_native_qstr_table[19])
      |                        ^
moduqr.c:404:51: note: in expansion of macro ‘MP_QSTR_packed’
  404 |     uqr_qr_locals_dict_table[3] = (mp_map_elem_t){MP_QSTR_packed, MP_OBJ_FROM_PTR(&rendered_qr_packed_obj)};
      |                                                   ^~~~~~~~~~~~~~
./build/uqr.config.h:188:24: note: (near initialization for ‘(anonymous).key’)
  188 | #define MP_QSTR_packed (mp_native_qstr_table[19])
      |                        ^
moduqr.c:404:51: note: in expansion of macro ‘MP_QSTR_packed’
  404 |     uqr_qr_locals_dict_table[3] = (mp_map_elem_t){MP_QSTR_packed, MP_OBJ_FROM_PTR(&rendered_qr_packed_obj)};
      |                                                   ^~~~~~~~~~~~~~
LINK build/moduqr.o
LinkError: build/moduqr.o: undefined symbol: mp_print_str
make: *** [../../py/dynruntime.mk:150: build/uqr.native.mpy] Error 1

[scgbckbone]

shouldn't this methods be included by default, even though MICROPY_ENABLE_DYNRUNTIME = 1? what am I missing?

[scgbckbone]

got it now - there is no mp_print_str in dynruntime.h and one should use mp_printf instead (or mp_vprintf)