Merge pull request #6 from orisintel/feature/dump-ending-in-line-break

feat(MigrateDumpCommand): Append new line after dumps to aid readabil…

Author: paulrrogers

src/Commands/MigrateDumpCommand.php

@@ -145,9 +145,11 @@ private static function mysqlDump(array $db_config, string $schema_sql_path) : i
 
         $output = self::reorderMigrationRows($output);
 
+        // Append reordered rows, and include a line break to make SCM diffs
+        // easier to read.
         file_put_contents(
             $schema_sql_path,
-            implode(PHP_EOL, $output),
+            implode(PHP_EOL, $output) . PHP_EOL,
             FILE_APPEND
         );
 
@@ -196,7 +198,7 @@ private static function pgsqlDump(array $db_config, string $schema_sql_path) : i
 
         file_put_contents(
             $schema_sql_path,
-            implode(PHP_EOL, $output),
+            implode(PHP_EOL, $output) . PHP_EOL,
             FILE_APPEND
         );
 

tests/Mysql/MigrateDumpTest.php

@@ -24,6 +24,8 @@ public function test_handle()
         $this->assertContains('CREATE TABLE `test_ms`', $result_sql);
         $this->assertContains('INSERT INTO `migrations`', $result_sql);
         $this->assertNotContains(' AUTO_INCREMENT=', $result_sql);
+        $last_character = mb_substr($result_sql, -1);
+        $this->assertRegExp("/[\r\n]\z/mu", $last_character);
     }
 
     public function test_reorderMigrationRows()

tests/Postgresql/MigrateDumpTest.php

@@ -19,5 +19,7 @@ public function test_handle()
         $result_sql = file_get_contents($this->schemaSqlPath);
         $this->assertRegExp('/CREATE TABLE (public\.)?test_ms /', $result_sql);
         $this->assertRegExp('/INSERT INTO (public\.)?migrations /', $result_sql);
+        $last_character = mb_substr($result_sql, -1);
+        $this->assertRegExp("/[\r\n]\z/mu", $last_character);
     }
-}
+}

tests/Sqlite/MigrateDumpTest.php

@@ -15,5 +15,7 @@ public function test_handle()
         $result_sql = file_get_contents($this->schemaSqlPath);
         $this->assertRegExp('/CREATE TABLE( IF NOT EXISTS)? "test_ms" /', $result_sql);
         $this->assertRegExp('/INSERT INTO "?migrations"? /', $result_sql);
+        $last_character = mb_substr($result_sql, -1);
+        $this->assertRegExp("/[\r\n]\z/mu", $last_character);
     }
 }