Add verification check for killed chains

Author: JohnnyWyles

.github/workflows/utility/checkVerificationCriteria.mjs

@@ -20,7 +20,7 @@
  *   - Uploads reports as artifacts
  *
  * ============================================================================
- * VERIFICATION CRITERIA (7 Checks)
+ * VERIFICATION CRITERIA (8 Checks)
  * ============================================================================
  *
  * 1. STANDARD LISTING
@@ -116,6 +116,15 @@
  *    - Pass: Either side has usd_amount >= $50 at 2% depth
  *    - Fail: Both sides < $50, or no pool found
  *
+ * 8. CHAIN STATUS
+ *    - Verifies the asset's chain is not marked as "killed"
+ *    - Check: chain_reg.getFileProperty(chainName, 'chain', 'status') !== 'killed'
+ *    - Exemption: Meme tokens (category includes "meme") skip this check
+ *    - Pass: Chain status is "live" or "upcoming" OR asset is a meme token
+ *    - Fail: Chain status is "killed" (unless meme token)
+ *    - Purpose: Prevents verification of assets on killed/deprecated chains
+ *      while allowing historical meme tokens to remain verified
+ *
  * ============================================================================
  * ALLOY AUTO-VERIFICATION
  * ============================================================================
@@ -521,6 +530,22 @@ function isMemeToken(zoneAsset) {
   return hasCategories(zoneAsset, ['meme']);
 }
 
+/**
+ * Check if a chain is marked as killed in the chain registry
+ *
+ * @param {string} chainName - Chain name to check
+ * @returns {boolean} True if chain is killed, false otherwise
+ */
+function isChainKilled(chainName) {
+  try {
+    const chainStatus = chain_reg.getFileProperty(chainName, 'chain', 'status');
+    return chainStatus === 'killed';
+  } catch (error) {
+    // If we can't read the chain status, assume it's not killed
+    return false;
+  }
+}
+
 //-- Verification Check Functions --
 
 /**
@@ -1112,6 +1137,53 @@ async function checkBidDepth(chainName, baseDenom, numiaPairs) {
   }
 }
 
+/**
+ * Check 8: Killed Chain Status
+ * Verifies that the asset's chain is not marked as "killed" in the chain registry
+ *
+ * Assets on killed chains should not be verified, and already-verified assets
+ * should be de-verified.
+ *
+ * Exemption: Meme tokens (category includes "meme") are allowed to remain verified
+ * even on killed chains, as they may have historical/cultural value.
+ *
+ * Per LISTING.md chain status requirement
+ *
+ * @param {string} chainName - Chain name to check
+ * @param {boolean} isMeme - Whether the asset is a meme token
+ */
+async function checkChainStatus(chainName, isMeme) {
+  try {
+    // Exemption: Meme tokens can remain verified on killed chains
+    if (isMeme) {
+      return {
+        passed: true,
+        details: 'Meme category: exempt from chain status check',
+        skipped: true
+      };
+    }
+
+    const chainIsKilled = isChainKilled(chainName);
+
+    if (chainIsKilled) {
+      return {
+        passed: false,
+        details: `Chain "${chainName}" is marked as killed in the chain registry`
+      };
+    }
+
+    return {
+      passed: true,
+      details: 'Chain is active'
+    };
+  } catch (error) {
+    return {
+      passed: true,  // Assume chain is active if we can't check
+      details: `Could not verify chain status: ${error.message}`
+    };
+  }
+}
+
 //-- Main Verification Function --
 
 /**
@@ -1134,6 +1206,7 @@ async function verifyAsset(zoneAsset, numiaTokens, numiaPairs, alloyMembersMap)
     comment: zoneAsset._comment || '',
     currently_verified: zoneAsset.osmosis_verified || false,
     is_meme: isMeme,
+    chainIsKilled: isChainKilled(chain_name),
     checks: {},
     alloyInfo: null
   };
@@ -1153,6 +1226,7 @@ async function verifyAsset(zoneAsset, numiaTokens, numiaPairs, alloyMembersMap)
   results.checks.logo = await checkLogo(chain_name, base_denom);
   results.checks.poolLiquidity = await checkPoolLiquidity(chain_name, base_denom, numiaTokens);
   results.checks.bidDepth = await checkBidDepth(chain_name, base_denom, numiaPairs);
+  results.checks.chainStatus = await checkChainStatus(chain_name, isMeme);
 
   // Determine overall pass/fail
   results.allChecksPassed = Object.values(results.checks).every(check => check.passed);
@@ -1179,9 +1253,15 @@ function generateMarkdownReport(verificationResults) {
   const alreadyVerified = verificationResults.filter(r => r.currently_verified);
   const failedChecks = verificationResults.filter(r => !r.allChecksPassed && !r.currently_verified);
 
+  // Filter killed chain assets (excluding meme tokens)
+  const killedChainAssetsVerified = verificationResults.filter(r => r.chainIsKilled && r.currently_verified && !r.is_meme);
+  const killedChainAssetsUnverified = verificationResults.filter(r => r.chainIsKilled && !r.currently_verified && !r.is_meme);
+
   markdown += `## Summary\n\n`;
   markdown += `- **Ready for Verification**: ${readyForVerification.length}\n`;
   markdown += `- **Failed Checks**: ${failedChecks.length}\n`;
+  markdown += `- **Killed Chain Assets (Verified)**: ${killedChainAssetsVerified.length} (require de-verification)\n`;
+  markdown += `- **Killed Chain Assets (Unverified)**: ${killedChainAssetsUnverified.length} (cannot be verified)\n`;
   markdown += `- **Total Checked**: ${verificationResults.length}\n\n`;
 
   // Ready for Verification section with asset links
@@ -1423,12 +1503,52 @@ function generateMarkdownReport(verificationResults) {
     });
   }
 
+  // Killed Chain Assets Section
+  if (killedChainAssetsVerified.length > 0 || killedChainAssetsUnverified.length > 0) {
+    markdown += `## ⚠️ Killed Chain Assets Requiring De-verification\n\n`;
+    markdown += `Assets from chains marked as "killed" in the chain registry (excluding meme tokens):\n\n`;
+
+    // Currently Verified subsection
+    if (killedChainAssetsVerified.length > 0) {
+      markdown += `### Currently Verified (${killedChainAssetsVerified.length})\n\n`;
+      markdown += `These verified assets belong to killed chains and should be de-verified:\n\n`;
+      markdown += `| Asset | Chain | Base Denom | Comment |\n`;
+      markdown += `|-------|-------|------------|----------|\n`;
+
+      killedChainAssetsVerified.forEach(r => {
+        const symbol = r.comment || r.base_denom.substring(0, 40);
+        markdown += `| ${symbol} | ${r.chain_name} | \`${r.base_denom}\` | ${r.comment || 'N/A'} |\n`;
+      });
+      markdown += '\n';
+    }
+
+    // Unverified subsection
+    if (killedChainAssetsUnverified.length > 0) {
+      markdown += `### Unverified (${killedChainAssetsUnverified.length})\n\n`;
+      markdown += `These unverified assets belong to killed chains and cannot be verified:\n\n`;
+      markdown += `| Asset | Chain | Base Denom | Comment |\n`;
+      markdown += `|-------|-------|------------|----------|\n`;
+
+      killedChainAssetsUnverified.forEach(r => {
+        const symbol = r.comment || r.base_denom.substring(0, 40);
+        markdown += `| ${symbol} | ${r.chain_name} | \`${r.base_denom}\` | ${r.comment || 'N/A'} |\n`;
+      });
+      markdown += '\n';
+    }
+
+    markdown += `**Note:** Meme tokens are exempt from this requirement and may remain verified on killed chains due to their historical/cultural value.\n\n`;
+  }
+
   return markdown;
 }
 
 function generateJSONReport(verificationResults) {
   const failedChecks = verificationResults.filter(r => !r.allChecksPassed && !r.currently_verified);
 
+  // Filter killed chain assets (excluding meme tokens)
+  const killedChainAssetsVerified = verificationResults.filter(r => r.chainIsKilled && r.currently_verified && !r.is_meme);
+  const killedChainAssetsUnverified = verificationResults.filter(r => r.chainIsKilled && !r.currently_verified && !r.is_meme);
+
   // Calculate failure breakdown
   const failureCounts = {
     standardListing: 0,
@@ -1437,7 +1557,8 @@ function generateJSONReport(verificationResults) {
     socials: 0,
     logo: 0,
     poolLiquidity: 0,
-    bidDepth: 0
+    bidDepth: 0,
+    chainStatus: 0
   };
 
   const socialsFailureReasons = {};
@@ -1488,12 +1609,30 @@ function generateJSONReport(verificationResults) {
       readyForVerification: verificationResults.filter(r => r.readyForVerification).length,
       alreadyVerified: verificationResults.filter(r => r.currently_verified).length,
       failedChecks: failedChecks.length,
+      killedChainAssetsVerified: killedChainAssetsVerified.length,
+      killedChainAssetsUnverified: killedChainAssetsUnverified.length,
       totalChecked: verificationResults.length
     },
     analysis: {
       failureBreakdown,
       socialsFailureReasons,
-      highLiquidityFailing
+      highLiquidityFailing,
+      killedChainAssets: {
+        verified: killedChainAssetsVerified.map(r => ({
+          chain_name: r.chain_name,
+          base_denom: r.base_denom,
+          comment: r.comment,
+          is_meme: r.is_meme,
+          chainIsKilled: r.chainIsKilled
+        })),
+        unverified: killedChainAssetsUnverified.map(r => ({
+          chain_name: r.chain_name,
+          base_denom: r.base_denom,
+          comment: r.comment,
+          is_meme: r.is_meme,
+          chainIsKilled: r.chainIsKilled
+        }))
+      }
     },
     results: verificationResults
   }, null, 2);

LISTING.md

@@ -46,6 +46,11 @@ Accessible liquidity of the asset on Osmosis:
      - This must work for all asset pairs in the pool
      - This would be impossible for pools with a swap fee (or spread) >=2%, which would require special consideration
 
+Chain Status:
+ - The asset's origin chain must not be marked as "killed" in the Cosmos Chain Registry
+   - Chains may be marked as killed when they are no longer operational
+   - Exception: Meme tokens (categorized as "meme") are exempt from this requirement and may remain verified on killed chains due to their historical/cultural value
+
 Asset appearance and functionality must be validated by Osmosis Zone maintainers. This includes:
  - Verifying the asset's details (name, [ticker] symbol, logo, description, socials) can be seen on Osmosis Zone
  - Verifying that the asset has a price on Osmosis Zone