Fix testnet IBC connection lookup and improve fallback robustness (#3296)

* allow testnet IBC channels to be verified

* Allow IBC transfer method

Author: JohnnyWyles

.github/workflows/utility/generate_assetlist_functions.mjs

@@ -8,12 +8,38 @@ chain_reg.setup();
 import * as zone from "./assetlist_functions.mjs";
 import { getAssetsPricing } from "./getPools.mjs";
 import { getAllRelatedAssets } from "./getRelatedAssets.mjs";
+import * as fs from 'fs';
+import * as path from 'path';
 
 //-- Global Constants --
 
 //This address corresponds to the native assset on all evm chains (e.g., wei on ethereum)
 const zero_address = "0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE";
 
+//-- Helper Functions --
+
+// Get IBC file property with zone-aware path selection
+// Determines _IBC directory based on the destination chain (osmosistestnet = testnet, osmosis = mainnet)
+function getIBCFilePropertyForZone(chainName1, chainName2, property) {
+  // chainName2 is the zone chain (osmosistestnet or osmosis) which tells us which _IBC to use
+  const isTestnetZone = chainName2 === "osmosistestnet";
+  const ibcDirectory = isTestnetZone
+    ? path.join(chain_reg.chainRegistryRoot, "testnets", "_IBC")
+    : path.join(chain_reg.chainRegistryRoot, "_IBC");
+
+  // Build the IBC file path
+  const sortedChains = [chainName1, chainName2].sort();
+  const fileName = `${sortedChains[0]}-${sortedChains[1]}.json`;
+  const filePath = path.join(ibcDirectory, fileName);
+
+  // Check if file exists and return the property
+  if (fs.existsSync(filePath)) {
+    return chain_reg.readJsonFile(filePath)[property];
+  }
+
+  return undefined;
+}
+
 //This defines with types of traces are considered essentially the same asset
 const originTraceTypes = [
   "ibc",
@@ -180,7 +206,7 @@ export function getAssetTrace(asset_data) {
 
 
   //--Find IBC Connection--
-  const channels = chain_reg.getIBCFileProperty(
+  const channels = getIBCFilePropertyForZone(
     asset_data.source_asset.chain_name,
     asset_data.chainName,
     "channels"
@@ -329,11 +355,33 @@ export async function setLocalAsset(asset_data) {
     return;
   }
 
-  // Only add trace if it was successfully retrieved
+  // Add trace if it was successfully retrieved, or create minimal trace from fallback
   if (trace?.chain?.path) {
     traces.push(trace);
   } else {
     console.log(`Warning: Using path from zone_asset for ${asset_data.zone_asset.chain_name}:${asset_data.zone_asset.base_denom} (IBC connection not found in registry)`);
+
+    // Create minimal trace from zone_asset to prevent downstream errors
+    // Path format: "transfer/channel-123/denom"
+    const segments = pathToUse.split("/");
+    const type = (asset_data.source_asset.base_denom.slice(0, 5) === "cw20:") ? "ibc-cw20" : "ibc";
+
+    // Extract channel ID from path (e.g., "channel-123" from segments[1])
+    const channelId = segments[1];
+
+    const minimalTrace = {
+      type: type,
+      counterparty: {
+        chain_name: asset_data.source_asset.chain_name,
+        base_denom: asset_data.source_asset.base_denom,
+        channel_id: channelId  // Will be set in setTransferMethods if needed
+      },
+      chain: {
+        channel_id: channelId,
+        path: pathToUse
+      }
+    };
+    traces.push(minimalTrace);
   }
 
   try {
@@ -1528,27 +1576,31 @@ export function setTransferMethods(asset_data) {
   if (asset_data.source_asset.chain_name !== asset_data.chainName) {
     const traces = getAssetProperty(asset_data.local_asset, "traces");
     const trace = traces?.[traces.length - 1];
-    const ibcTransferMethod = {
-      name: "Osmosis IBC Transfer",
-      type: "ibc",
-      counterparty: {
-        chainName: trace.counterparty.chain_name,
-        chainId: chain_reg.getFileProperty(
-          trace.counterparty.chain_name,
-          "chain",
-          "chain_id"
-        ),
-        sourceDenom: trace.counterparty.base_denom,
-        port: trace.counterparty.port ?? "transfer",
-        channelId: trace.counterparty.channel_id
-      },
-      chain: {
-        port: trace.chain.port ?? "transfer",
-        channelId: trace.chain.channel_id,
-        path: trace.chain.path
+
+    // Only add IBC transfer method if we have a valid trace with required fields
+    if (trace?.counterparty?.chain_name && trace?.chain?.channel_id) {
+      const ibcTransferMethod = {
+        name: "Osmosis IBC Transfer",
+        type: "ibc",
+        counterparty: {
+          chainName: trace.counterparty.chain_name,
+          chainId: chain_reg.getFileProperty(
+            trace.counterparty.chain_name,
+            "chain",
+            "chain_id"
+          ),
+          sourceDenom: trace.counterparty.base_denom,
+          port: trace.counterparty.port ?? "transfer",
+          channelId: trace.counterparty.channel_id
+        },
+        chain: {
+          port: trace.chain.port ?? "transfer",
+          channelId: trace.chain.channel_id,
+          path: trace.chain.path
+        }
       }
+      transferMethods.push(ibcTransferMethod);
     }
-    transferMethods.push(ibcTransferMethod);
   }
 
   asset_data.frontend.transferMethods = transferMethods;