Skip to content

Commit 14d1c56

Browse files
WebKit ARM64 Builderclaude
andcommitted
Fix ICU static library handling - remove incorrect rename operation
- vcpkg arm64-windows-static already produces static libraries with 's' prefix - Remove Move-Item operations that try to rename non-existent files - Static libraries are already correctly named: sicudt.lib, sicuin.lib, etc. - Eliminates the Move-Item path not found error 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 5fdada7 commit 14d1c56

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

windows-release.ps1

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -338,19 +338,9 @@ if (Test-Path -Path $WebKitBuild/lib64) {
338338

339339
Copy-Item $WebKitBuild/cmakeconfig.h $output/include/cmakeconfig.h
340340

341-
if ($CMAKE_BUILD_TYPE -eq "Release") {
342-
Move-Item $ICU_STATIC_LIBRARY/icudt.lib $ICU_STATIC_LIBRARY/sicudt.lib
343-
Move-Item $ICU_STATIC_LIBRARY/icutu.lib $ICU_STATIC_LIBRARY/sicutu.lib
344-
Move-Item $ICU_STATIC_LIBRARY/icuio.lib $ICU_STATIC_LIBRARY/sicuio.lib
345-
Move-Item $ICU_STATIC_LIBRARY/icuin.lib $ICU_STATIC_LIBRARY/sicuin.lib
346-
Move-Item $ICU_STATIC_LIBRARY/icuuc.lib $ICU_STATIC_LIBRARY/sicuuc.lib
347-
} elseif ($CMAKE_BUILD_TYPE -eq "Debug") {
348-
Move-Item $ICU_STATIC_LIBRARY/icudt.lib $ICU_STATIC_LIBRARY/sicudtd.lib
349-
Move-Item $ICU_STATIC_LIBRARY/icutu.lib $ICU_STATIC_LIBRARY/sicutud.lib
350-
Move-Item $ICU_STATIC_LIBRARY/icuio.lib $ICU_STATIC_LIBRARY/sicuiod.lib
351-
Move-Item $ICU_STATIC_LIBRARY/icuin.lib $ICU_STATIC_LIBRARY/sicuind.lib
352-
Move-Item $ICU_STATIC_LIBRARY/icuuc.lib $ICU_STATIC_LIBRARY/sicuucd.lib
353-
}
341+
# vcpkg static builds already produce files with 's' prefix, so no renaming needed
342+
# The static libraries are already named sicudt.lib, sicuin.lib, etc.
343+
Write-Host ":: ICU static libraries are already properly named"
354344

355345
Add-Content -Path $output/include/cmakeconfig.h -Value "`#define BUN_WEBKIT_VERSION `"$BUN_WEBKIT_VERSION`""
356346

0 commit comments

Comments
 (0)