Skip to content

Feedback: Update/#222 product page update #307 #312

@ciaranschutte

Description

@ciaranschutte

Screenshot 2023-09-07 at 2 32 52 PM

  • Github, User Docs "button style links", "Installation Instructions" don't go anywhere
  • the info sections eg. "Metadata Validation" have the "pointer" cursor (cursor: pointer) which tells the user it's clickable.... but these sections aren't clickable

https://github.com/overture-stack/website/blob/develop/src/components/LinkHelper/index.js

  • use const
  let isBrowser = typeof window !== 'undefined';
  let width = isBrowser && window.innerWidth;
  const mobileViewPort = isBrowser && width <= 767;
  const tabletViewPort = isBrowser && 767 < width && width <= 1023;
  const desktopViewPort = isBrowser && 1023 < width && width <= 1215;
  const desktopWideViewPort = isBrowser && 1215 < width && width <= 1407;
  const desktopUltraWideViewPort = isBrowser && 1408 < width;
  • use regular css?

font size use rem


      className={`yellow-button__text ${isProductPage && 'yellow-button__product-page-text'}`}

why logic?


half bem / half logic css?


duplicate images. variations on sizes as indivual images when theyre svgs you can resize.

Metadata

Metadata

Assignees

No one assigned

    Labels

    new-featureRequest is a new feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions