Skip to content

Commit 5c1cdb9

Browse files
authored
Merge pull request #83 from ovh-ux/fix/loading-button
Delete usage of div in button (loaders)
2 parents 92a99b5 + 2088923 commit 5c1cdb9

File tree

4 files changed

+74
-24
lines changed

4 files changed

+74
-24
lines changed

packages/oui-loader/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ oui-loader is a package which provide styles for the loader component.
3636

3737
```html:preview
3838
<button class="oui-button oui-button_secondary" disabled>
39-
<div class="oui-loader oui-loader_s oui-loader_inline">
40-
<div class="oui-loader__container">
41-
<div class="oui-loader__image"></div>
42-
</div>
43-
</div>
39+
<span class="oui-loader oui-loader_s oui-loader_inline">
40+
<span class="oui-loader__container">
41+
<span class="oui-loader__image"></span>
42+
</span>
43+
</span>
4444
Loading...
4545
</button>
4646
```

packages/oui-loader/_mixins.less

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
}
2626

2727
&__container {
28+
display: block;
2829
position: relative;
2930
background: none;
3031
}

packages/oui-loader/loader_m.svg

Lines changed: 19 additions & 0 deletions
Loading

packages/oui-loader/loader_s.svg

Lines changed: 49 additions & 19 deletions
Loading

0 commit comments

Comments
 (0)