Merge pull request #713 from owen-it/minor-revisions

Minor revisions

Author: anteriovieira

config/audit.php

@@ -98,17 +98,13 @@
     | those from the empty values check. For example when auditing
     | model retrieved events which will never have new and old values.
     |
-    | When using empty_values => true, you can still exclude certain events
-    | with empty values by specifying them in disallowed_empty_values.
     |
     */
 
     'empty_values'         => true,
     'allowed_empty_values' => [
         'retrieved'
     ],
-    'disallowed_empty_values' => [
-    ],
 
     /*
     |--------------------------------------------------------------------------

src/Auditor.php

@@ -70,9 +70,8 @@ public function execute(Auditable $model)
         // Check if we want to avoid storing empty values
         $allowEmpty = Config::get('audit.empty_values');
         $explicitAllowEmpty = in_array($model->getAuditEvent(), Config::get('audit.allowed_empty_values', []));
-        $explicitDisallowEmpty = in_array($model->getAuditEvent(), Config::get('audit.disallowed_empty_values', []));
 
-        if ($explicitDisallowEmpty || (!$allowEmpty && !$explicitAllowEmpty)) {
+        if (!$allowEmpty && !$explicitAllowEmpty) {
             if (
                 empty($model->toAudit()['new_values']) &&
                 empty($model->toAudit()['old_values'])

tests/Unit/AuditTest.php

@@ -88,9 +88,7 @@ public function itResolvesAuditDataIncludingUserAttributes()
             'audit_tags'       => null,
             'audit_created_at' => $audit->getSerializedDate($audit->created_at),
             'audit_updated_at' => $audit->getSerializedDate($audit->updated_at),
-            'user_id'          => '1',
             'user_type'        => User::class,
-            'user_is_admin'    => '1',
             'user_first_name'  => 'rick',
             'user_last_name'   => 'Sanchez',
             'user_email'       => '[email protected]',