Are these two test cases duplicates?

[dungsil]

I'm wondering if this entry is just a duplicate or if it has some other meaning.

purl-spec/tests/spec/specification-test.json

Lines 4 to 21 in 9041aa7

	{
	"description": "a scheme is always required",
	"test_group": "base",
	"test_type": "parse",
	"input": "[email protected]",
	"expected_output": null,
	"expected_failure": true,
	"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
	},
	{
	"description": "a scheme is always required",
	"test_group": "base",
	"test_type": "parse",
	"input": "[email protected]",
	"expected_output": null,
	"expected_failure": true,
	"expected_failure_reason": "Should fail to parse a PURL from invalid canonical purl input"
	},

[johnmhoran]

Hi @dungsil and thank you for spotting this. I've only given it a quick glance but it looks like I started a second test object by copying the first and then got sidetracked and ended up prematurely committing and pushing. I'll take a close look tomorrow and followup with you..

BTW, I don't think there is such a thing as an invalid canonical purl input. ;-)

[johnmhoran]

@dungsil Looking at GitHub blame, if I'm reading it correctly it appears that these two tests -- identical but for the expected_failure_reason -- were created four months ago by @pombredanne . In any event, they need some TLC -- I'll put together a PR that uses a different input for the second of them and create another "expected_failure": true test. (We could use more of those throughout the tests.)

[dungsil]

Hello @johnmhoran,

Thank you for your response. While reviewing the tests, I found another similar case:

purl-spec/tests/spec/specification-test.json

Lines 39 to 53 in 9041aa7

	"description": "a type is always required",
	"test_group": "base",
	"test_type": "parse",
	"input": "pkg:[email protected]",
	"expected_output": null,
	"expected_failure": true,
	"expected_failure_reason": "Should fail to parse a PURL from invalid purl input"
	},
	{
	"description": "a type is always required",
	"test_group": "base",
	"test_type": "parse",
	"input": "pkg:[email protected]",
	"expected_output": null,
	"expected_failure": true,

And... it seems there are a few issues.

For example: a mismatch between the description and the input value

purl-spec/tests/spec/specification-test.json

Lines 106 to 121 in 9041aa7

	{
	"description": "check for type that starts with number",
	"test_group": "base",
	"test_type": "build",
	"input": {
	"type": null,
	"namespace": null,
	"name": "nginx",
	"version": "0.8.9",
	"qualifiers": null,
	"subpath": null
	},
	"expected_output": null,
	"expected_failure": true,
	"expected_failure_reason": "Should fail to build a PURL from invalid input components"
	},