fix: incorrect response content-type behaviour (#22)

* fix: incorrect response content-type behaviour

* chore: remove redundant parts of oas

Author: vwong

src/__tests__/fixtures/request-parameters-header/baseline.json

@@ -210,5 +210,24 @@
       }
     },
     "type": "warning"
+  },
+  {
+    "code": "request.content-type.incompatible",
+    "message": "Request Content-Type header is incompatible with the mime-types the spec accepts to consume",
+    "mockDetails": {
+      "interactionDescription": "should error about incorrect request content type",
+      "interactionState": "[none]",
+      "location": "[root].interactions[9].request.headers.content-type",
+      "value": "unknown"
+    },
+    "specDetails": {
+      "location": "[root].paths./submit.post.requestBody.content",
+      "pathMethod": "post",
+      "pathName": "/submit",
+      "value": [
+        "application/json"
+      ]
+    },
+    "type": "error"
   }
 ]

src/__tests__/fixtures/request-parameters-header/oas.yaml

@@ -43,6 +43,19 @@ paths:
           description: Bad request
           content:
             application/json: {}
+  /submit:
+    post:
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema: {}
+      responses:
+        "400":
+          description: Bad request
+          content:
+            "application/json":
+              schema: {}
   /no-response:
     get:
       responses:

src/__tests__/fixtures/request-parameters-header/pact.json

@@ -190,6 +190,24 @@
           "Content-Type": "application/json"
         }
       }
+    },
+    {
+      "description": "should error about incorrect request content type",
+      "providerState": "",
+      "request": {
+        "method": "POST",
+        "path": "/submit",
+        "headers": {
+          "content-type": "unknown"
+        },
+        "body": "unknown"
+      },
+      "response": {
+        "status": 400,
+        "headers": {
+          "Content-Type": "application/json"
+        }
+      }
     }
   ]
 }

src/__tests__/fixtures/request-parameters-header/results.json

@@ -199,5 +199,24 @@
       }
     },
     "type": "warning"
+  },
+  {
+    "code": "request.content-type.incompatible",
+    "message": "Request Content-Type header is incompatible with the mime-types the spec accepts to consume",
+    "mockDetails": {
+      "interactionDescription": "should error about incorrect request content type",
+      "interactionState": "[none]",
+      "location": "[root].interactions[9].request.headers.content-type",
+      "value": "unknown"
+    },
+    "specDetails": {
+      "location": "[root].paths./submit.post.requestBody.content",
+      "pathMethod": "post",
+      "pathName": "/submit",
+      "value": [
+        "application/json"
+      ]
+    },
+    "type": "error"
   }
 ]

src/compare/responseHeader.ts

@@ -24,6 +24,17 @@ export function* compareResHeader(
 ): Iterable<Result> {
   const { method, oas, operation, path } = route.store;
 
+  const allAvailableResponseContentTypes =
+    operation.produces ||
+    Object.entries(operation.responses).reduce(
+      (acc: string[], [_status, response]) => {
+        return [
+          ...acc,
+          ...Object.keys(dereferenceOas(response || {}, oas)?.content || {}),
+        ];
+      },
+      [],
+    );
   const availableResponseContentType =
     operation.produces ||
     Object.keys(
@@ -41,7 +52,7 @@ export function* compareResHeader(
   const responseContentType =
     responseHeaders.get("content-type")?.split(";")[0] || "";
 
-  if (responseContentType && !availableResponseContentType.length) {
+  if (responseContentType && !allAvailableResponseContentTypes.length) {
     yield {
       code: "response.content-type.unknown",
       message: