Skip to content

Fix SELFDESTRUCT tests in evm-test-suite #218

@0xRVE

Description

@0xRVE

Tracing logic was added to pallet-revive here: paritytech/polkadot-sdk#10244

Tests were added to evm-test-suite here: paritytech/evm-test-suite#131

Three issues:

  1. selfdestruct diff test is expected to have a prestate entry but we get rid of it in prestate_tracing.rs:collect_trace().
  2. create_and_destruct diff test expects for the poststate to have no balance because prestate.balance == poststate.balance. For us the difference between prestate.balance and poststate.balance is the existential deposit, which means our poststate has balance field.
  3. create_and_destruct no_diff expects to only have an entry for the Tracing.sol contract but we also list its child contract. In prestate_tracing.rs:exit_child_span() we could remove the address of the child contract because it was created and destructed in the same tx?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions