frame-system: Ensure that `BlockNumber` is strictly increasing #10180

bkchr · 2025-10-31T22:09:01Z

Otherwise a block should fail to build/import.

bkchr · 2025-10-31T22:09:20Z

/cmd prdoc --audience runtime_dev --bump patch

…time_dev --bump patch'

paritytech-workflow-stopper · 2025-11-05T17:13:40Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/19109547910
Failed job name: run-frame-omni-bencher

bkchr · 2025-11-06T11:14:41Z

/cmd fmt

paritytech-release-backport-bot · 2025-11-06T14:53:29Z

Created backport PR for stable2506:

[stable2506] Backport #10180 #10228 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10180-to-stable2506
git worktree add --checkout .worktree/backport-10180-to-stable2506 backport-10180-to-stable2506
cd .worktree/backport-10180-to-stable2506
git reset --hard HEAD^
git cherry-pick -x 12f9d5987303545220466c62fa5e0621abc72025
git push --force-with-lease

paritytech-release-backport-bot · 2025-11-06T14:53:32Z

Created backport PR for stable2509:

[stable2509] Backport #10180 #10229 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10180-to-stable2509
git worktree add --checkout .worktree/backport-10180-to-stable2509 backport-10180-to-stable2509
cd .worktree/backport-10180-to-stable2509
git reset --hard HEAD^
git cherry-pick -x 12f9d5987303545220466c62fa5e0621abc72025
git push --force-with-lease

Otherwise a block should fail to build/import. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

pgherveou · 2025-11-06T16:05:45Z

@bkchr

team member reported this

2025-11-06 16:37:20.850 ERROR      offchain-worker runtime: panicked at /Users/robert/polkadot-sdk/substrate/frame/system/src/lib.rs:1916:3:
assertion `left == right` failed: Block number must be strictly increasing.
  left: 2
 right: 1
2025-11-06 16:37:20.851 ERROR      offchain-worker offchain-worker: Error running offchain workers at 0x2264734e5b4cc6fe29385b6d574c32830f7b7e045588a1edf5b9949f7aae5755: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instru
ction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x2b3671 - revive_dev_runtime.wasm!__rustc[5224e6b81cd82a8f]::rust_begin_unwind
    1:  0x1f106 - revive_dev_runtime.wasm!core::panicking::panic_fmt::hc4e5121f822df63e
    2:  0x1f3a6 - revive_dev_runtime.wasm!core::panicking::assert_failed_inner::h4f260632bc718f35
    3:  0x4fd06 - revive_dev_runtime.wasm!core::panicking::assert_failed::hf4acac8520b9fbad
    4: 0x1ac1a5 - revive_dev_runtime.wasm!frame_system::<impl frame_system::pallet::Pallet<T>>::initialize::h930c70874146ee2d
    5: 0x21539d - revive_dev_runtime.wasm!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::offchain_worker::h569646f48af8d586
    6: 0x1cae96 - revive_dev_runtime.wasm!OffchainWorkerApi_offchain_worker

haven't investigated yet, just letting you know as this seems related to these changes

bkchr · 2025-11-06T16:07:07Z

I will take a look. Ty for posting.

0xRVE · 2025-11-06T16:12:45Z

@bkchr
Happened in revive-dev-node. Let me know if you need me to reproduce

Otherwise a block should fail to build/import. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

When calling `offchain-worker` we were initializing the entire `System` again with the same block we are running on top of. However, with [the change to require strictly increasing block numbers](#10180) the offchain-worker was failing. This is now solved by just registering the missing digests. The rest of the changes done by `initialize` are not important for offchain workers. The pull request ensures that we are actually testing this behavior of the offchain worker now.

bkchr · 2025-11-06T21:25:12Z

Fixed here: #10235

Backport #10180 into `stable2506` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Egor_P <[email protected]>

When calling `offchain-worker` we were initializing the entire `System` again with the same block we are running on top of. However, with [the change to require strictly increasing block numbers](#10180) the offchain-worker was failing. This is now solved by just registering the missing digests. The rest of the changes done by `initialize` are not important for offchain workers. The pull request ensures that we are actually testing this behavior of the offchain worker now. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

When calling `offchain-worker` we were initializing the entire `System` again with the same block we are running on top of. However, with [the change to require strictly increasing block numbers](#10180) the offchain-worker was failing. This is now solved by just registering the missing digests. The rest of the changes done by `initialize` are not important for offchain workers. The pull request ensures that we are actually testing this behavior of the offchain worker now. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 405e0bd)

Backport #10180 into `stable2509` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot.  --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

frame-system: Ensure that BlockNumber is strictly increasing

26b6eb3

Otherwise a block should fail to build/import.

bkchr requested a review from a team as a code owner October 31, 2025 22:09

bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 31, 2025

Update from github-actions[bot] running command 'prdoc --audience run…

18c4a1a

…time_dev --bump patch'

sandreim approved these changes Oct 31, 2025

View reviewed changes

bkontur approved these changes Oct 31, 2025

View reviewed changes

nkpar approved these changes Oct 31, 2025

View reviewed changes

bkchr added 2 commits November 3, 2025 10:07

Fix benchmarks

fb3d41d

Fix tests

0eac572

skunert approved these changes Nov 5, 2025

View reviewed changes

bkchr added 2 commits November 5, 2025 12:49

More fixes

1fb35b1

Fix benchmark

019baf6

Fix it in a different way

9e5cfa9

Update from github-actions[bot] running command 'fmt'

6572115

xermicus approved these changes Nov 6, 2025

View reviewed changes

bkchr added this pull request to the merge queue Nov 6, 2025

Merged via the queue into master with commit 12f9d59 Nov 6, 2025
264 of 275 checks passed

bkchr deleted the bkchr-system-strictly-increasing branch November 6, 2025 14:26

bkchr added A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-stable2509 Pull request must be backported to the stable2509 release branch labels Nov 6, 2025

paritytech-release-backport-bot bot mentioned this pull request Nov 6, 2025

[stable2506] Backport #10180 #10228

Merged

paritytech-release-backport-bot bot mentioned this pull request Nov 6, 2025

[stable2509] Backport #10180 #10229

Merged

bkchr added a commit that referenced this pull request Nov 6, 2025

frame-system: Ensure that BlockNumber is strictly increasing (#10180)

315ca63

Otherwise a block should fail to build/import. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

marian-radu pushed a commit that referenced this pull request Nov 6, 2025

frame-system: Ensure that BlockNumber is strictly increasing (#10180)

2a7cb4e

Otherwise a block should fail to build/import. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bkchr mentioned this pull request Nov 6, 2025

offchain-worker: Do not intialize the entire System again #10235

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

frame-system: Ensure that `BlockNumber` is strictly increasing #10180

frame-system: Ensure that `BlockNumber` is strictly increasing #10180

Uh oh!

bkchr commented Oct 31, 2025

Uh oh!

bkchr commented Oct 31, 2025

Uh oh!

paritytech-workflow-stopper bot commented Nov 5, 2025

Uh oh!

bkchr commented Nov 6, 2025

Uh oh!

Uh oh!

paritytech-release-backport-bot bot commented Nov 6, 2025

Uh oh!

paritytech-release-backport-bot bot commented Nov 6, 2025

Uh oh!

pgherveou commented Nov 6, 2025

Uh oh!

bkchr commented Nov 6, 2025

Uh oh!

0xRVE commented Nov 6, 2025 •

edited

Loading

Uh oh!

bkchr commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

frame-system: Ensure that BlockNumber is strictly increasing #10180

frame-system: Ensure that BlockNumber is strictly increasing #10180

Uh oh!

Conversation

bkchr commented Oct 31, 2025

Uh oh!

bkchr commented Oct 31, 2025

Uh oh!

paritytech-workflow-stopper bot commented Nov 5, 2025

Uh oh!

bkchr commented Nov 6, 2025

Uh oh!

Uh oh!

paritytech-release-backport-bot bot commented Nov 6, 2025

Uh oh!

paritytech-release-backport-bot bot commented Nov 6, 2025

Uh oh!

pgherveou commented Nov 6, 2025

Uh oh!

bkchr commented Nov 6, 2025

Uh oh!

0xRVE commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

frame-system: Ensure that `BlockNumber` is strictly increasing #10180

frame-system: Ensure that `BlockNumber` is strictly increasing #10180

0xRVE commented Nov 6, 2025 •

edited

Loading