Patched results for branch: master #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def check_password(self, password: str): | ||
| return self.pwd_hash == md5(password.encode('utf-8')).hexdigest() | ||
| return self.pwd_hash == sha256(password.encode('utf-8')).hexdigest() |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic hashing algorithm on sensitive data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 4 issues.
Changed hashing algorithm from md5 to sha256
The diff shows that the hashing algorithm used for password encryption has been changed from md5 to sha256. This change is reflected in the import statement and in the password comparison method.Refactor SQL query parameters from dictionary to list
The diff changes the way SQL query parameters are handled. Previously, a dictionary was used to store parameters, which were then inserted into the query string using named placeholders. The diff changes this to use a list of parameters and positional placeholders. This change affects both the LIMIT and OFFSET clauses of a SELECT query and the VALUES clause of an INSERT query.