Skip to content

Commit 7de7f06

Browse files
lillesChromium LUCI CQ
authored andcommitted
Wait a full frame for the scroll timeline to become inactive
Modified scroll-animation-inactive-timeline.html test to allow for snapshotting happening after first style/layout update. See proposal in: whatwg/html#11613 Bug: 384523570 Change-Id: I44320e55325206e308d86b2cfd60668202cfe4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7141918 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1543754}
1 parent 0069f44 commit 7de7f06

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

third_party/blink/web_tests/TestExpectations

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1550,7 +1550,6 @@ crbug.com/435625756 external/wpt/css/css-values/urls/referrer-policy/unsafe-url/
15501550
# Failing WPT tests with the RunSnapshotPostLayoutStateSteps flag enabled
15511551
crbug.com/384523570 virtual/run-snapshot-post-layout/external/wpt/scroll-animations/scroll-timelines/effect-updateTiming.html [ Failure ]
15521552
crbug.com/384523570 virtual/run-snapshot-post-layout/external/wpt/scroll-animations/scroll-timelines/scroll-animation-effect-phases.tentative.html [ Failure ]
1553-
crbug.com/384523570 virtual/run-snapshot-post-layout/external/wpt/scroll-animations/scroll-timelines/scroll-animation-inactive-timeline.html [ Failure ]
15541553
crbug.com/384523570 virtual/run-snapshot-post-layout/external/wpt/scroll-animations/scroll-timelines/updating-the-finished-state.html [ Pass Timeout ]
15551554

15561555
# Tests only passing with RunSnapshotPostLayoutStateSteps enabled

third_party/blink/web_tests/external/wpt/scroll-animations/scroll-timelines/scroll-animation-inactive-timeline.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
// Wait for new animation frame which allows the timeline to compute new
3737
// current time.
3838
await waitForNextFrame();
39+
await waitForNextFrame();
3940
assert_equals(animation.timeline.currentTime, null,
4041
'Sanity check the timeline is inactive.');
4142
// Play the animation when the timeline is inactive.
@@ -62,6 +63,7 @@
6263
// Wait for new animation frame which allows the timeline to compute new
6364
// current time.
6465
await waitForNextFrame();
66+
await waitForNextFrame();
6567
assert_equals(animation.timeline.currentTime, null,
6668
'Sanity check the timeline is inactive.');
6769
// Play the animation when the timeline is inactive.
@@ -91,6 +93,7 @@
9193
// Wait for new animation frame which allows the timeline to compute new
9294
// current time.
9395
await waitForNextFrame();
96+
await waitForNextFrame();
9497
assert_equals(animation.timeline.currentTime, null,
9598
'Sanity check the timeline is inactive.');
9699
// Set start time when the timeline is inactive.
@@ -138,6 +141,7 @@
138141
scroller.style.overflow = 'visible';
139142
scroller.scrollTop;
140143
await waitForNextFrame();
144+
await waitForNextFrame();
141145
assert_equals(animation.timeline.currentTime, null,
142146
'Sanity check the timeline is inactive.');
143147
assert_equals(animation.playState, 'running',

0 commit comments

Comments
 (0)