Merge pull request #483 from phodal/master

update Agent rules

Author: phodal

AGENTS.md

@@ -1,80 +1,56 @@
 ## Core Rules
 
-- Current project is a Kotlin multiplatform project, always consider the multiplatform aspect, JS, WASM, Desktop JVM, Android, iOS
-- Current project is a Kotlin multiplatform project, always consider the multiplatform aspect, JS, WASM, Desktop JVM, Android, iOS
-- Current project is a Kotlin multiplatform project, always consider the multiplatform aspect, JS, WASM, Desktop JVM, Android, iOS
+- **Kotlin Multiplatform**: Always consider all platforms: JS, WASM, Desktop JVM, Android, iOS
+- **Build & Test**: Always run build and tests before completing tasks
+- **Preserve Intent**: If existing solution doesn't work, preserve its intent
+- **Module Clean**: Use `./gradlew :module:clean` instead of global clean
+- **Test Scripts**: Put temporary scripts under `docs/test-scripts`
+- **Logs**: Check `~/.autodev/logs/autodev-app.log` for debugging
 
-Rest:
+## KMP Best Practices
 
-- Always run the build and tests before completing a task, making sure they pass.
-- If an existing request/solution does not work, preserve its intent.
-- Do not run `./gradlew clean`. Clean only the specific module, e.g., `./gradlew :mpp-core:clean`.
-- Put temporary test scripts under `docs/test-scripts`.
+- Use `expect`/`actual` for platform-specific code, for example `Platform`
+- **@JsExport**: Use concrete classes (not interfaces), `Promise` (not `Flow`)
+- **WASM**: Avoid emoji and UTF-8 in code
+- **i18n**: Run `./gradlew :mpp-ui:generateI18n4kFiles`
 
-## Debug
+## Renderer System
 
-- Log save in `~/.autodev/logs/autodev-app.log`
+When modifying `CodingAgentRenderer`, update ALL implementations:
+- **Kotlin**: `DefaultCodingAgentRenderer`, `ComposeRenderer`, `JewelRenderer`, `ServerSideRenderer`, `JsRendererAdapter`
+- **TypeScript**: `BaseRenderer.ts`, `CliRenderer.ts`, `ServerRenderer.ts`, `TuiRenderer.ts`
+- **VSCode**: `mpp-vscode/src/bridge/mpp-core.ts`, `mpp-vscode/src/providers/chat-view.ts`
+- **JVM CLI**: `CodingCliRenderer`, `ConsoleRenderer`
 
-## Summary
+## Design System
 
-- Omit a summary if the problem is simple. For bug fixes, summarize as: Problem → Root Cause → Solution. Keep summary
-  short if need. Use Mermaid for long chat only.
+- **CLI/TUI**: Use `semanticInk`/`semanticChalk` from `mpp-ui/src/jsMain/typescript/design-system/`
+- **Compose**: Use `AutoDevColors` or `MaterialTheme.colorScheme`
+- **NO hardcoded colors** - always use design tokens
+- **Docs**: `docs/design-system-color.md`, `docs/design-system-compose.md`
 
-## Kotlin Multiplatform \(KMP\) Best Practices for `mpp-core` and `mpp-ui`
+## Quick Commands
 
-- Use `expect`/`actual` for platform-specific code \(e.g., file I/O on JVM/JS/Wasm\).
-- Check export first, if some functions not working well with CLI (TypeScript)
-- 在 Kotlin/JS 的 @JsExport 中：
-    - Avoid `Flow`, use `Promise`
-    - ✅ 使用具体类作为返回类型和参数类型
-    - ❌ 避免使用接口类型（JS 端无法正确处理接口的类型转换）
-- For WASM platform, we should not use emoji and utf8 in code.
-- Use ./gradlew :mpp-ui:generateI18n4kFiles for i18n
-
-## Design System \(Color & Theme\)
-
-- **CLI/TUI (TypeScript)**: Use `mpp-ui/src/jsMain/typescript/design-system/` → Import `semanticInk` / `semanticChalk`
-- **Compose (Desktop/Android)**: Use `AutoDevColors` from `cc.unitmesh.devins.ui.compose.theme` → Or `MaterialTheme.colorScheme`
-- **DO NOT hardcode colors** \(e.g., `Color(0xFF...)` or `#hex`\). Always use design tokens for consistency across platforms.
-- **Docs**: See `docs/design-system-color.md` (TypeScript) and `docs/design-system-compose.md` (Kotlin Compose)
-
-## AutoDev CLI Quick Test
-
-1. Build MPP Core: `cd /Volumes/source/ai/autocrud && ./gradlew :mpp-core:assembleJsPackage`
-2. Build and run MPP CLI: `cd mpp-ui && npm run build && npm run start`
-
-## IntelliJ IDEA Plugin (mpp-idea)
+**CLI Test:**
+```bash
+./gradlew :mpp-core:assembleJsPackage
+cd mpp-ui && npm run build && npm run start
+```
 
-`mpp-idea` is a standalone Gradle project with `includeBuild` dependency on parent project.
+**IDEA Plugin:**
 
-**Build Commands:**
 ```bash
-# Compile (from project root)
 cd mpp-idea && ../gradlew compileKotlin
-
-# Run tests (JewelRendererTest uses JUnit 5, no IntelliJ Platform required)
 cd mpp-idea && ../gradlew test --tests "cc.unitmesh.devins.idea.renderer.JewelRendererTest"
-
-# Build plugin
 cd mpp-idea && ../gradlew buildPlugin
 ```
 
-**Notes:**
-- Do NOT use `./gradlew :mpp-idea:compileKotlin` from root - use `cd mpp-idea && ../gradlew` instead
-- `IdeaAgentViewModelTest` requires IntelliJ Platform Test Framework
-- `JewelRendererTest` can run standalone with JUnit 5
-
-## VSCode Plugin (mpp-vscode)
-
-`mpp-vscode` is a standalone npm package with `devDependencies` on parent project.
-
-## Release
+**Release:**
 
-1. modify version in `gradle.properties`
-2. publish cli version: `cd mpp-ui && npm publish:remote`
-
-### Desktop Compose App
-
-1. publish Desktop: `git tag compose-vVersion` (same in `gradle.properties`), `git push origin compose-vVersion`
-2. draft release in GitHub, run gh cli: `gh release create compose-vVersion --draft`
+```bash
+# 1. Update version in gradle.properties
+# 2. CLI: cd mpp-ui && npm publish:remote
+# 3. Desktop: git tag compose-vX.X.X && git push origin compose-vX.X.X
+# 4. gh release create compose-vX.X.X --draft
+```
 

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/executor/CodingAgentExecutor.kt

@@ -62,6 +62,9 @@ class CodingAgentExecutor(
     private val recentToolCalls = mutableListOf<String>()
     private val MAX_REPEAT_COUNT = 3
 
+    // Track task execution time
+    private var taskStartTime: Long = 0L
+
     /**
      * 执行 Agent 任务
      */
@@ -71,13 +74,17 @@ class CodingAgentExecutor(
         onProgress: (String) -> Unit = {}
     ): AgentResult {
         resetExecution()
+
+        // Start tracking execution time
+        taskStartTime = Platform.getCurrentTimestamp()
+
         conversationManager = ConversationManager(llmService, systemPrompt)
-        
+
         // Set up token tracking callback to update renderer
         conversationManager?.onTokenUpdate = { tokenInfo ->
             renderer.updateTokenInfo(tokenInfo)
         }
-        
+
         val initialUserMessage = buildInitialUserMessage(task)
 
         onProgress("🚀 CodingAgent started")
@@ -103,7 +110,8 @@ class CodingAgentExecutor(
 
             val allToolCalls = toolCallParser.parseToolCalls(llmResponse.toString())
             if (allToolCalls.isEmpty()) {
-                renderer.renderTaskComplete()
+                val executionTimeMs = Platform.getCurrentTimestamp() - taskStartTime
+                renderer.renderTaskComplete(executionTimeMs)
                 break
             }
 
@@ -122,7 +130,9 @@ class CodingAgentExecutor(
             conversationManager!!.addToolResults(toolResultsText)
 
             if (isTaskComplete(llmResponse.toString())) {
-                renderer.renderTaskComplete()
+                val executionTimeMs = Platform.getCurrentTimestamp() - taskStartTime
+                val toolsUsedCount = steps.size
+                renderer.renderTaskComplete(executionTimeMs, toolsUsedCount)
                 break
             }
 
@@ -140,6 +150,7 @@ class CodingAgentExecutor(
         steps.clear()
         edits.clear()
         recentToolCalls.clear()
+        taskStartTime = 0L
     }
 
     private fun buildInitialUserMessage(task: AgentTask): String {

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/render/CodingAgentRenderer.kt

@@ -35,7 +35,13 @@ interface CodingAgentRenderer {
         metadata: Map<String, String> = emptyMap()
     )
 
-    fun renderTaskComplete()
+    /**
+     * Render task completion message with execution time and tool usage statistics.
+     *
+     * @param executionTimeMs Total execution time in milliseconds from task start to completion
+     * @param toolsUsedCount Number of tools used during execution
+     */
+    fun renderTaskComplete(executionTimeMs: Long = 0L, toolsUsedCount: Int = 0)
     fun renderFinalResult(success: Boolean, message: String, iterations: Int)
     fun renderError(message: String)
     fun renderRepeatWarning(toolName: String, count: Int)

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/render/DefaultCodingAgentRenderer.kt

@@ -68,8 +68,21 @@ class DefaultCodingAgentRenderer : BaseRenderer() {
         println()
     }
 
-    override fun renderTaskComplete() {
-        println("✓ Task marked as complete\n")
+    override fun renderTaskComplete(executionTimeMs: Long, toolsUsedCount: Int) {
+        val parts = mutableListOf<String>()
+
+        if (executionTimeMs > 0) {
+            val seconds = executionTimeMs / 1000.0
+            val rounded = (seconds * 100).toLong() / 100.0
+            parts.add("${rounded}s")
+        }
+
+        if (toolsUsedCount > 0) {
+            parts.add("$toolsUsedCount tools")
+        }
+
+        val info = if (parts.isNotEmpty()) " (${parts.joinToString(", ")})" else ""
+        println("✓ Task marked as complete$info\n")
     }
 
     override fun renderFinalResult(success: Boolean, message: String, iterations: Int) {

mpp-core/src/jsMain/kotlin/cc/unitmesh/agent/RendererExports.kt

@@ -102,7 +102,7 @@ interface JsCodingAgentRenderer {
     fun renderToolResult(toolName: String, success: Boolean, output: String?, fullOutput: String?)
 
     // Status and completion methods
-    fun renderTaskComplete()
+    fun renderTaskComplete(executionTimeMs: Double = 0.0, toolsUsedCount: Int = 0)
     fun renderFinalResult(success: Boolean, message: String, iterations: Int)
     fun renderError(message: String)
     fun renderRepeatWarning(toolName: String, count: Int)
@@ -155,8 +155,8 @@ class JsRendererAdapter(private val jsRenderer: JsCodingAgentRenderer) : CodingA
         jsRenderer.renderToolResult(toolName, success, output, fullOutput)
     }
 
-    override fun renderTaskComplete() {
-        jsRenderer.renderTaskComplete()
+    override fun renderTaskComplete(executionTimeMs: Long, toolsUsedCount: Int) {
+        jsRenderer.renderTaskComplete(executionTimeMs.toDouble(), toolsUsedCount)
     }
 
     override fun renderFinalResult(success: Boolean, message: String, iterations: Int) {

mpp-idea/src/main/kotlin/cc/unitmesh/devins/idea/renderer/JewelRenderer.kt

@@ -407,9 +407,33 @@ class JewelRenderer : BaseRenderer() {
         }
     }
 
-    override fun renderTaskComplete() {
+    override fun renderTaskComplete(executionTimeMs: Long, toolsUsedCount: Int) {
         _taskCompleted.value = true
         _isProcessing.value = false
+
+        // Add a completion message with execution time and tool usage to the timeline
+        val parts = mutableListOf<String>()
+
+        if (executionTimeMs > 0) {
+            val seconds = executionTimeMs / 1000.0
+            val rounded = (seconds * 100).toLong() / 100.0
+            parts.add("${rounded}s")
+        }
+
+        if (toolsUsedCount > 0) {
+            parts.add("$toolsUsedCount tools")
+        }
+
+        if (parts.isNotEmpty()) {
+            _timeline.update { items ->
+                items + TimelineItem.MessageItem(
+                    message = Message(
+                        role = MessageRole.ASSISTANT,
+                        content = "✓ Task marked as complete (${parts.joinToString(", ")})"
+                    )
+                )
+            }
+        }
     }
 
     override fun renderFinalResult(success: Boolean, message: String, iterations: Int) {

mpp-server/src/main/kotlin/cc/unitmesh/server/render/ServerSideRenderer.kt

@@ -43,7 +43,7 @@ class ServerSideRenderer : CodingAgentRenderer {
         eventChannel.trySend(AgentEvent.ToolResult(toolName, success, output))
     }
 
-    override fun renderTaskComplete() {
+    override fun renderTaskComplete(executionTimeMs: Long, toolsUsedCount: Int) {
         // Will be handled by renderFinalResult
     }
 

mpp-ui/src/commonMain/kotlin/cc/unitmesh/devins/ui/compose/agent/ComposeRenderer.kt

@@ -55,7 +55,6 @@ class ComposeRenderer : BaseRenderer() {
     val errorMessage: String? get() = _errorMessage
 
     private var _taskCompleted by mutableStateOf(false)
-    val taskCompleted: Boolean get() = _taskCompleted
 
     private var _executionStartTime by mutableStateOf(0L)
     val executionStartTime: Long get() = _executionStartTime
@@ -73,7 +72,6 @@ class ComposeRenderer : BaseRenderer() {
     private var _currentViewingFile by mutableStateOf<String?>(null)
     val currentViewingFile: String? get() = _currentViewingFile
 
-    // Task tracking from task-boundary tool
     private val _tasks = mutableStateListOf<TaskInfo>()
     val tasks: List<TaskInfo> = _tasks
 
@@ -465,9 +463,33 @@ class ComposeRenderer : BaseRenderer() {
         }
     }
 
-    override fun renderTaskComplete() {
+    override fun renderTaskComplete(executionTimeMs: Long, toolsUsedCount: Int) {
         _taskCompleted = true
         _isProcessing = false
+
+        // Add a completion message with execution time and tool usage to the timeline
+        val parts = mutableListOf<String>()
+
+        if (executionTimeMs > 0) {
+            val seconds = executionTimeMs / 1000.0
+            val rounded = (seconds * 100).toLong() / 100.0
+            parts.add("${rounded}s")
+        }
+
+        if (toolsUsedCount > 0) {
+            parts.add("$toolsUsedCount tools")
+        }
+
+        if (parts.isNotEmpty()) {
+            _timeline.add(
+                TimelineItem.MessageItem(
+                    message = Message(
+                        role = MessageRole.ASSISTANT,
+                        content = "✓ Task marked as complete (${parts.joinToString(", ")})"
+                    )
+                )
+            )
+        }
     }
 
     override fun renderFinalResult(

mpp-ui/src/jsMain/typescript/agents/render/BaseRenderer.ts

@@ -115,7 +115,7 @@ export abstract class BaseRenderer implements JsCodingAgentRenderer {
   abstract renderLLMResponseEnd(): void;
   abstract renderToolCall(toolName: string, paramsStr: string): void;
   abstract renderToolResult(toolName: string, success: boolean, output: string | null, fullOutput?: string | null, metadata?: Record<string, string>): void;
-  abstract renderTaskComplete(): void;
+  abstract renderTaskComplete(executionTimeMs?: number, toolsUsedCount?: number): void;
   abstract renderFinalResult(success: boolean, message: string, iterations: number): void;
   abstract renderError(message: string): void;
   abstract renderRepeatWarning(toolName: string, count: number): void;

mpp-ui/src/jsMain/typescript/agents/render/CliRenderer.ts

@@ -524,8 +524,20 @@ export class CliRenderer extends BaseRenderer {
     return null;
   }
 
-  renderTaskComplete(): void {
-    console.log(semanticChalk.successBold('\n✓ Task marked as complete\n'));
+  renderTaskComplete(executionTimeMs: number = 0, toolsUsedCount: number = 0): void {
+    const parts: string[] = [];
+
+    if (executionTimeMs > 0) {
+      const seconds = (executionTimeMs / 1000).toFixed(2);
+      parts.push(`${seconds}s`);
+    }
+
+    if (toolsUsedCount > 0) {
+      parts.push(`${toolsUsedCount} tools`);
+    }
+
+    const info = parts.length > 0 ? ` (${parts.join(', ')})` : '';
+    console.log(semanticChalk.successBold(`\n✓ Task marked as complete${info}\n`));
   }
 
   renderFinalResult(success: boolean, message: string, iterations: number): void {