feat(agent): skip tool result rendering for live terminal #453

Pass metadata to renderers and prevent duplicate rendering when a live terminal session is active. This avoids showing tool results already displayed in the LiveTerminal UI.

Author: phodal

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/executor/CodingAgentExecutor.kt

@@ -275,11 +275,14 @@ class CodingAgentExecutor(
             val contentHandlerResult = checkForLongContent(toolName, fullOutput ?: "", executionResult)
             val displayOutput = contentHandlerResult?.content ?: fullOutput
 
-            // **关键改动**: 检查是否是 live session，如果是则跳过渲染 (输出已经在 LiveTerminal 中显示)
-            val isLiveSession = executionResult.metadata["isLiveSession"] == "true"
-            if (!isLiveSession) {
-                renderer.renderToolResult(toolName, stepResult.success, stepResult.result, displayOutput)
-            }
+            // **关键改动**: 传递 metadata 给 renderer，用于检查是否是 live session
+            renderer.renderToolResult(
+                toolName, 
+                stepResult.success, 
+                stepResult.result, 
+                displayOutput,
+                executionResult.metadata
+            )
 
             val currentToolType = toolName.toToolType()
             if ((currentToolType == ToolType.WriteFile) && executionResult.isSuccess) {

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/render/CodingAgentRenderer.kt

@@ -13,7 +13,7 @@ interface CodingAgentRenderer {
 
     // Tool execution methods
     fun renderToolCall(toolName: String, paramsStr: String)
-    fun renderToolResult(toolName: String, success: Boolean, output: String?, fullOutput: String?)
+    fun renderToolResult(toolName: String, success: Boolean, output: String?, fullOutput: String?, metadata: Map<String, String> = emptyMap())
 
     // Status and completion methods
     fun renderTaskComplete()

mpp-core/src/commonMain/kotlin/cc/unitmesh/agent/render/DefaultCodingAgentRenderer.kt

@@ -47,7 +47,7 @@ class DefaultCodingAgentRenderer : BaseRenderer() {
         println("🔧 /$toolName $paramsStr")
     }
 
-    override fun renderToolResult(toolName: String, success: Boolean, output: String?, fullOutput: String?) {
+    override fun renderToolResult(toolName: String, success: Boolean, output: String?, fullOutput: String?, metadata: Map<String, String>) {
         val icon = if (success) "✓" else "✗"
         print("   $icon $toolName")
 

mpp-core/src/jsMain/kotlin/cc/unitmesh/agent/RendererExports.kt

@@ -75,7 +75,7 @@ class JsRendererAdapter(private val jsRenderer: JsCodingAgentRenderer) : CodingA
         jsRenderer.renderToolCall(toolName, paramsStr)
     }
 
-    override fun renderToolResult(toolName: String, success: Boolean, output: String?, fullOutput: String?) {
+    override fun renderToolResult(toolName: String, success: Boolean, output: String?, fullOutput: String?, metadata: Map<String, String>) {
         jsRenderer.renderToolResult(toolName, success, output, fullOutput)
     }
 

mpp-ui/src/commonMain/kotlin/cc/unitmesh/devins/ui/compose/agent/ComposeRenderer.kt

@@ -211,10 +211,19 @@ class ComposeRenderer : BaseRenderer() {
         toolName: String,
         success: Boolean,
         output: String?,
-        fullOutput: String?
+        fullOutput: String?,
+        metadata: Map<String, String>
     ) {
         val summary = formatToolResultSummary(toolName, success, output)
 
+        // Check if this was a live terminal session - skip rendering if so
+        val isLiveSession = metadata["isLiveSession"] == "true"
+        if (isLiveSession) {
+            // Live terminal already rendered - just mark tool call as complete
+            _currentToolCall = null
+            return
+        }
+
         // For shell commands, use special terminal output rendering
         val toolType = toolName.toToolType()
         if (toolType == ToolType.Shell && output != null) {