Merge pull request #154 from rmbl/feature/humanize-implicit-label

Humanize the implicit label of symfony form types

Author: bocharsky-bw

src/Visitor/Php/Symfony/FormTypeLabelImplicit.php

@@ -84,6 +84,7 @@ public function enterNode(Node $node): ?Node
 
                 $label = $node->args[0]->value->value;
                 if (!empty($label)) {
+                    $label = $this->humanize($label);
                     if (null !== $location = $this->getLocation($label, $node->getAttribute('startLine'), $node, ['domain' => $domain])) {
                         $this->lateCollect($location);
                     }
@@ -93,4 +94,12 @@ public function enterNode(Node $node): ?Node
 
         return null;
     }
+
+    /**
+     * @see Symfony\Component\Form\FormRenderer::humanize()
+     */
+    private function humanize(string $text): string
+    {
+        return ucfirst(strtolower(trim(preg_replace(['/([A-Z])/', '/[_\s]+/'], ['_$1', ' '], $text))));
+    }
 }

tests/Functional/Visitor/Php/Symfony/FormTypeLabelImplicitTest.php

@@ -25,11 +25,11 @@ public function testExtract()
         $collection = $this->getSourceLocations(new FormTypeLabelImplicit(), Resources\Php\Symfony\ImplicitLabelType::class);
 
         $this->assertCount(5, $collection, print_r($collection, true));
-        $this->assertEquals('find1', $collection->get(0)->getMessage());
-        $this->assertEquals('bigger_find2', $collection->get(1)->getMessage());
-        $this->assertEquals('camelFind3', $collection->get(2)->getMessage());
+        $this->assertEquals('Find1', $collection->get(0)->getMessage());
+        $this->assertEquals('Bigger find2', $collection->get(1)->getMessage());
+        $this->assertEquals('Camel find3', $collection->get(2)->getMessage());
 
         //issue87: support for Ignore annotation
-        $this->assertEquals('issue87-willBeAdded', $collection->get(3)->getMessage());
+        $this->assertEquals('Issue87-will be added', $collection->get(3)->getMessage());
     }
 }

tests/Functional/Visitor/Php/Symfony/FormTypeLabelTest.php

@@ -55,11 +55,11 @@ public function testTranslationDomain()
         $this->assertEquals('admin0', $messageA->getContext()['domain']);
 
         $messageB = $collection->get(1);
-        $this->assertEquals('test_b', $messageB->getMessage());
+        $this->assertEquals('Test b', $messageB->getMessage());
         $this->assertEquals('admin1', $messageB->getContext()['domain']);
 
         $messageC = $collection->get(2);
-        $this->assertEquals('test_c', $messageC->getMessage());
+        $this->assertEquals('Test c', $messageC->getMessage());
         $this->assertNull($messageC->getContext()['domain']);
     }
 }