Move test cases for report-possibly-nonexistent-array-offset

Author: SplotyCode

tests/PHPStan/Analyser/nsrt/for-loop-expr.php

@@ -50,28 +50,3 @@ function getItemsArray(array $items): array
 	assertType('array<string>', $items);
 	return $items;
 }
-
-/**
- * @param array<string> $items
- */
-function skipFirstElement(array $items): void
-{
-	for ($i = 1; count($items) > $i; ++$i) {
-		$items[$i] = 'hello';
-	}
-
-	assertType('array<string>', $items);
-}
-
-/**
- * @param positive-int $skip
- * @param array<string> $items
- */
-function skipByX(int $skip, array $items): void
-{
-	for ($i = $skip; count($items) > $i; ++$i) {
-		$items[$i] = 'hello';
-	}
-
-	assertType('array<string>', $items);
-}

tests/PHPStan/Rules/Arrays/data/report-possibly-nonexistent-array-offset.php

@@ -58,3 +58,26 @@ public function nonEmpty(array $a): void
 	}
 
 }
+
+/**
+ * @param array<string> $items
+ */
+function skipFirstElement(array $items): void
+{
+	for ($i = 1; count($items) > $i; ++$i) {
+		$element = $items[$i];
+		\PHPStan\Testing\assertType('string', $element);
+	}
+}
+
+/**
+ * @param positive-int $skip
+ * @param array<string> $items
+ */
+function skipByX(int $skip, array $items): void
+{
+	for ($i = $skip; count($items) > $i; ++$i) {
+		$element = $items[$i];
+		\PHPStan\Testing\assertType('string', $element);
+	}
+}