feat(staking): skip minimum self delegation check at genesis block (#15)

Author: 0xHansLee

x/staking/client/cli/tx.go

@@ -411,7 +411,7 @@ func newBuildCreateValidatorMsg(clientCtx client.Context, txf tx.Factory, fs *fl
 	if err != nil {
 		return txf, nil, err
 	}
-	if err := msg.Validate(valAc); err != nil {
+	if err := msg.Validate(valAc, false); err != nil {
 		return txf, nil, err
 	}
 

x/staking/keeper/msg_server.go

@@ -37,7 +37,11 @@ func (k msgServer) CreateValidator(ctx context.Context, msg *types.MsgCreateVali
 		return nil, sdkerrors.ErrInvalidAddress.Wrapf("invalid validator address: %s", err)
 	}
 
-	if err := msg.Validate(k.validatorAddressCodec); err != nil {
+	sdkCtx := sdk.UnwrapSDKContext(ctx)
+
+	// skip validation that if the token is greater than minimum self delegation amount at genesis block
+	skipMinSelfDelValidation := sdkCtx.BlockHeight() == 0
+	if err := msg.Validate(k.validatorAddressCodec, skipMinSelfDelValidation); err != nil {
 		return nil, err
 	}
 
@@ -79,7 +83,6 @@ func (k msgServer) CreateValidator(ctx context.Context, msg *types.MsgCreateVali
 		return nil, err
 	}
 
-	sdkCtx := sdk.UnwrapSDKContext(ctx)
 	cp := sdkCtx.ConsensusParams()
 	if cp.Validator != nil {
 		pkType := pk.Type()
@@ -149,7 +152,7 @@ func (k msgServer) CreateValidator(ctx context.Context, msg *types.MsgCreateVali
 	}
 
 	// delegation amount must be greater than or equal to minimum self delegation when creating validator
-	if msg.Value.Amount.LT(validator.MinSelfDelegation) {
+	if msg.Value.Amount.LT(validator.MinSelfDelegation) && !skipMinSelfDelValidation {
 		return nil, types.ErrSelfDelegationBelowMinimum
 	}
 

x/staking/keeper/msg_server_test.go

@@ -238,7 +238,8 @@ func (s *KeeperTestSuite) TestMsgCreateValidator() {
 	for _, tc := range testCases {
 		tc := tc
 		s.T().Run(tc.name, func(t *testing.T) {
-			_, err := msgServer.CreateValidator(ctx, tc.input)
+			cachedCtx := ctx.WithBlockHeight(1)
+			_, err := msgServer.CreateValidator(cachedCtx, tc.input)
 			if tc.expErr {
 				require.Error(err)
 				require.Contains(err.Error(), tc.expErrMsg)

x/staking/types/msg.go

@@ -48,7 +48,7 @@ func NewMsgCreateValidator(
 }
 
 // Validate validates the MsgCreateValidator sdk msg.
-func (msg MsgCreateValidator) Validate(ac address.Codec) error {
+func (msg MsgCreateValidator) Validate(ac address.Codec, skipMinSelfDelValidation bool) error {
 	// note that unmarshaling from bech32 ensures both non-empty and valid
 	_, err := ac.StringToBytes(msg.ValidatorAddress)
 	if err != nil {
@@ -82,7 +82,7 @@ func (msg MsgCreateValidator) Validate(ac address.Codec) error {
 		)
 	}
 
-	if msg.Value.Amount.LT(msg.MinSelfDelegation) {
+	if msg.Value.Amount.LT(msg.MinSelfDelegation) && !skipMinSelfDelValidation {
 		return ErrSelfDelegationBelowMinimum
 	}