Skip to content

Commit 3938fbe

Browse files
committed
Merge branch 'v32' into release/33.3.2rc2
2 parents 8327a9f + f9d1d2a commit 3938fbe

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All notable changes to `dash-ag-grid` will be documented in this file.
44
This project adheres to [Semantic Versioning](https://semver.org/).
55
Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source Dash AG Grid repo
66

7+
## [32.3.2] - 2025-09-17
8+
9+
### Fixed
10+
- [#403](https://github.com/plotly/dash-ag-grid/issues/403) fix "Maximum update depth exceeded" error
11+
712
## [32.3.2rc1] - 2025-08-05
813

914
### Fixed

tests/test_column_state.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
alt_colState = [
8585
{
8686
"colId": "price",
87-
"width": 198,
87+
"width": 200,
8888
"hide": False,
8989
"pinned": None,
9090
"sort": "asc",
@@ -239,7 +239,7 @@ def loadState(n):
239239

240240
dash_duo.find_element("#get-column-state-button").click()
241241
testState = colState.copy()
242-
testState[1]["width"] = 198
242+
testState[1]["width"] = 200
243243
until(
244244
lambda: json.dumps(testState)
245245
in dash_duo.find_element("#reset-column-state-grid-pre").text,

tests/test_sizing_buttons.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import pytest
12
import dash_ag_grid as dag
23
from dash import Dash, html, dcc, Output, Input, no_update, ctx, State
34
import requests
@@ -118,6 +119,7 @@ def selected(state, oldState, opts):
118119
oldValue = dash_duo.find_element("#columnState").text
119120

120121

122+
@pytest.mark.flaky(max_runs=5, min_passes=1)
121123
def test_sb002_sizing_buttons(dash_duo):
122124
app = Dash(__name__)
123125

@@ -204,6 +206,7 @@ def selected(state):
204206
for x in columnDefs:
205207
assert x["field"] in oldValue
206208

209+
time.sleep(.5) # allow window size to change
207210
for x in ["sizeToFit", "responsiveSizeToFit"]:
208211
dash_duo.find_element(f"#{x}").click()
209212
if x != "responsiveSizeToFit":
@@ -339,7 +342,7 @@ def selected(state, oldState, opts):
339342
)
340343
oldValue = dash_duo.find_element("#columnState").text
341344

342-
345+
@pytest.mark.flaky(max_runs=5, min_passes=1)
343346
def test_sb004_sizing_buttons(dash_duo):
344347
app = Dash(__name__)
345348

@@ -427,6 +430,7 @@ def selected(state):
427430
oldValue = dash_duo.find_element("#columnState").text
428431
for x in columnDefs:
429432
assert x["field"] in oldValue
433+
time.sleep(.5)
430434

431435
for x in ["sizeToFit", "responsiveSizeToFit"]:
432436
dash_duo.find_element(f"#{x}").click()
@@ -448,7 +452,7 @@ def selected(state):
448452
assert oldValue == dash_duo.find_element("#columnState").get_attribute(
449453
"innerText"
450454
)
451-
time.sleep(.2) # allow window size to change
455+
time.sleep(.5) # allow window size to change
452456
dash_duo.find_element(f"#{x}").click()
453457
until(
454458
lambda: oldValue

0 commit comments

Comments
 (0)