Skip to content

Commit a7837b5

Browse files
committed
bumping to 31.3.4 for AG Grid, adjusting tests that were failing due to timing
1 parent 2301614 commit a7837b5

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
"dependencies": {
3434
"@emotion/react": "^11.11.3",
3535
"@emotion/styled": "^11.11.0",
36-
"ag-grid-community": "31.3.2",
37-
"ag-grid-enterprise": "31.3.2",
38-
"ag-grid-react": "31.3.2",
36+
"ag-grid-community": "31.3.4",
37+
"ag-grid-enterprise": "31.3.4",
38+
"ag-grid-react": "31.3.4",
3939
"@mui/icons-material": "^5.15.7",
4040
"@mui/material": "^5.15.7",
4141
"d3-format": "^3.1.0",

tests/test_event_listeners.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,13 @@ def test_el001_event_listener(dash_duo):
5252

5353
# Test left click.
5454
grid.get_cell(1, 2).click()
55-
cellClicked = dash_duo.find_element('#log').text
56-
assert json.loads(cellClicked).get('value') == 15
55+
until(lambda: json.loads(dash_duo.find_element('#log').text).get('value') == 15, timeout=3)
5756

5857
# Test right click
5958
action = utils.ActionChains(dash_duo.driver)
6059
action.context_click(grid.get_cell(0, 2)).perform()
61-
cellClicked = dash_duo.find_element('#log').text
62-
assert json.loads(cellClicked).get('value') == 13
63-
assert json.loads(cellClicked).get('contextMenu')
60+
until(lambda: json.loads(dash_duo.find_element('#log').text).get('value') == 13, timeout=3)
61+
until(lambda: json.loads(dash_duo.find_element('#log').text).get('contextMenu'), timeout=3)
6462

6563
def test_el002_event_listener(dash_duo):
6664
app = Dash(__name__, suppress_callback_exceptions=True)
@@ -86,7 +84,7 @@ def test_el002_event_listener(dash_duo):
8684

8785
# Test left click.
8886
grid.get_cell(1, 2).click()
89-
assert dash_duo.find_element('#log').text == "rawr"
87+
until(lambda: dash_duo.find_element('#log').text == "rawr", timeout=3)
9088

9189
def test_el003_event_listener(dash_duo):
9290
app = Dash(__name__, suppress_callback_exceptions=True)

0 commit comments

Comments
 (0)