Skip to content

Commit 21e49a9

Browse files
authored
Merge pull request #3247 from pnp/version-4
Release 4.12.0
2 parents 3b504ac + b7c8478 commit 21e49a9

File tree

6 files changed

+67
-71
lines changed

6 files changed

+67
-71
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
77

8+
## 4.12.0 - 2025-Apr 14
9+
10+
- Windows 11 introduces an issue with the use of nodejs Spawn when not run through Shell. Updating Spawn Methods where needed to include shell:true.
11+
812
## 4.11.0 - 2025-Mar-17
913

1014
- Update of presets/all

debug/serve/plumbing/run.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@ const isWin = process.platform === "win32";
1515
spawn(isWin ? "npx.cmd" : "npx", ["tsc", "-p", "./debug/serve/tsconfig.json", "--watch"], {
1616
cwd: projectRoot,
1717
stdio: "inherit",
18+
shell:true,
1819
});
1920

2021
// run our server
2122
spawn("node", ["./serve.js"], {
2223
cwd: __dirname,
2324
stdio: "inherit",
25+
shell:true
2426
});

debug/spfx/pnpjs-local-debug-start.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@ const isWin = process.platform === "win32";
1010
child_process.spawn(isWin ? "npx.cmd" : "npx", ["tsc", "-p", "./packages/tsconfig-watch.json"], {
1111
cwd: projectRoot,
1212
stdio: "inherit",
13+
shell:true,
1314
});
1415

1516
// run our server
1617
child_process.spawn(isWin ? "npx.cmd" : "npx", ["gulp", "serve", "--nobrowser"], {
1718
cwd: __dirname,
1819
stdio: "inherit",
20+
shell: true,
1921
});

package-lock.json

Lines changed: 53 additions & 65 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
"name": "@pnp/monorepo",
33
"private": true,
44
"type": "module",
5-
"version": "4.11.0",
5+
"version": "4.12.0",
66
"description": "A JavaScript library for SharePoint & Graph development.",
77
"devDependencies": {
88
"@azure/identity": "4.8.0",
99
"@azure/msal-browser": "3.28.1",
1010
"@azure/msal-node": "2.16.2",
1111
"@microsoft/microsoft-graph-types": "2.40.0",
1212
"@pnp/buildsystem": "^4.0.1",
13-
"@pnp/logging": "^4.10.0",
13+
"@pnp/logging": "^4.11.0",
1414
"@types/chai": "4.3.19",
1515
"@types/chai-as-promised": "7.1.8",
1616
"@types/core-js": "2.5.8",
@@ -32,9 +32,9 @@
3232
"string-replace-loader": "3.1.0",
3333
"tslib": "2.8.1",
3434
"typescript": "4.x",
35-
"webpack": "5.98.0",
35+
"webpack": "5.99.5",
3636
"webpack-cli": "5.1.4",
37-
"webpack-dev-server": "5.2.0",
37+
"webpack-dev-server": "5.2.1",
3838
"yargs": "17.7.2"
3939
},
4040
"scripts": {

test/sp/query-escaping.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe("Query Escaping", function () {
3232
expect(value).to.eq("_api/web/getFileByUrl(@p1)?%40p1=%27%2Fsites%2Fdev%2Fdocuments%2Ffolder%27%27s+root%2Fsomething.txt%27");
3333

3434
value = getTestValue(sp.web.getFolderByServerRelativePath("/sites/dev/documents/folder's root/"));
35-
expect(value).to.eq(`_api/web/getFolderByServerRelativePath(decodedUrl='${encodeURIComponent("/sites/dev/documents/folder''s root/")}')`);
35+
expect(value).to.eq("_api/web/getFolderByServerRelativePath(decodedUrl='/sites/dev/documents/folder''s root/')");
3636

3737
value = getTestValue(sp.web.folders.getByUrl("/sites/dev/documents/folder's root/"));
3838
expect(value).to.eq(`_api/web/folders('${encodeURIComponent("/sites/dev/documents/folder''s root/")}')`);
@@ -47,7 +47,7 @@ describe("Query Escaping", function () {
4747
expect(value).to.eq("_api/web/getFileByUrl(@p1)?%40p1=%27%2Fsites%2Fdev%2Fshared+documents%2F%23%21%40%23%24%25%5E%26%28%29_%2B-%2Freadme.md%27");
4848

4949
value = getTestValue(sp.web.getFolderByServerRelativePath("/sites/dev/documents/folder #!@#$%^&()_+-"));
50-
expect(value).to.eq("_api/web/getFolderByServerRelativePath(decodedUrl='%2Fsites%2Fdev%2Fdocuments%2Ffolder%20%23!%40%23%24%25%5E%26()_%2B-')");
50+
expect(value).to.eq("_api/web/getFolderByServerRelativePath(decodedUrl='/sites/dev/documents/folder #!@#$%^&()_+-')");
5151

5252
value = getTestValue(sp.web.folders.getByUrl("/sites/dev/documents/folder #!@#$%^&()_+-"));
5353
expect(value).to.eq("_api/web/folders('%2Fsites%2Fdev%2Fdocuments%2Ffolder%20%23!%40%23%24%25%5E%26()_%2B-')");

0 commit comments

Comments
 (0)