Merge pull request #77 from pnp/file-editor-functions-and-fixes

File editor functions and fixes

Author: tavikukko

package-lock.json

@@ -1,31 +1,31 @@
 {
   "name": "sp-editor",
-  "version": "7.1.2",
+  "version": "7.2.0",
   "private": true,
   "homepage": ".",
   "dependencies": {
-    "@azure/msal-browser": "^3.24.0",
-    "@azure/msal-react": "^2.1.0",
+    "@azure/msal-browser": "^3.26.1",
+    "@azure/msal-react": "^2.1.1",
     "@craco/craco": "^7.1.0",
-    "@fluentui/react": "^8.120.9",
-    "@ionic/react": "^8.3.1",
-    "@microsoft/mgt": "^4.2.5",
-    "@microsoft/mgt-react": "^4.2.5",
+    "@fluentui/react": "^8.121.6",
+    "@ionic/react": "^8.3.3",
+    "@microsoft/mgt": "^4.3.0",
+    "@microsoft/mgt-react": "^4.3.0",
     "@microsoft/microsoft-graph-client": "^3.0.7",
     "@minoru/react-dnd-treeview": "^3.4.4",
-    "@pnp/graph": "^4.5.0",
-    "@pnp/logging": "^4.5.0",
-    "@pnp/msaljsclient": "^4.5.0",
-    "@pnp/sp": "^4.5.0",
-    "@pnp/sp-admin": "^4.5.0",
-    "@reduxjs/toolkit": "^2.2.7",
-    "@testing-library/jest-dom": "^6.5.0",
+    "@pnp/graph": "^4.6.0",
+    "@pnp/logging": "^4.6.0",
+    "@pnp/msaljsclient": "^4.6.0",
+    "@pnp/sp": "^4.6.0",
+    "@pnp/sp-admin": "^4.6.0",
+    "@reduxjs/toolkit": "^2.3.0",
+    "@testing-library/jest-dom": "^6.6.2",
     "@testing-library/react": "^16.0.1",
     "@testing-library/user-event": "^14.5.2",
-    "@types/jest": "^29.5.13",
-    "@types/node": "^22.6.1",
-    "@types/react": "^18.3.8",
-    "@types/react-dom": "^18.3.0",
+    "@types/jest": "^29.5.14",
+    "@types/node": "^22.7.9",
+    "@types/react": "^18.3.12",
+    "@types/react-dom": "^18.3.1",
     "@uifabric/theme-samples": "^7.5.33",
     "@vscode/codicons": "^0.0.36",
     "gsap": "^3.12.5",
@@ -35,8 +35,8 @@
     "react-dom": "^18.3.1",
     "react-live": "^4.1.7",
     "react-redux": "^9.1.2",
-    "react-router": "^6.26.2",
-    "react-router-dom": "^6.26.2",
+    "react-router": "^6.27.0",
+    "react-router-dom": "^6.27.0",
     "redux": "^5.0.1",
     "textarea-caret": "^3.1.0",
     "typesafe-actions": "^5.1.0",

package.json

@@ -14,13 +14,14 @@ import { AuthenticationResult } from "../response/AuthenticationResult.js";
 import { EventCallbackFunction } from "../event/EventMessage.js";
 import { ClearCacheRequest } from "../request/ClearCacheRequest.js";
 import { InitializeApplicationRequest } from "../request/InitializeApplicationRequest.js";
+import { EventType } from "../event/EventType.js";
 export interface IPublicClientApplication {
     initialize(request?: InitializeApplicationRequest): Promise<void>;
     acquireTokenPopup(request: PopupRequest): Promise<AuthenticationResult>;
     acquireTokenRedirect(request: RedirectRequest): Promise<void>;
     acquireTokenSilent(silentRequest: SilentRequest): Promise<AuthenticationResult>;
     acquireTokenByCode(request: AuthorizationCodeRequest): Promise<AuthenticationResult>;
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>): string | null;
     removeEventCallback(callbackId: string): void;
     addPerformanceCallback(callback: PerformanceCallbackFunction): string;
     removePerformanceCallback(callbackId: string): boolean;

public/@azure/msal-browser/app/IPublicClientApplication.d.ts

@@ -16,6 +16,7 @@ import { EventCallbackFunction } from "../event/EventMessage.js";
 import { ClearCacheRequest } from "../request/ClearCacheRequest.js";
 import { EndSessionPopupRequest } from "../request/EndSessionPopupRequest.js";
 import { InitializeApplicationRequest } from "../request/InitializeApplicationRequest.js";
+import { EventType } from "../event/EventType.js";
 /**
  * The PublicClientApplication class is the object exposed by the library to perform authentication and authorization functions in Single Page Applications
  * to obtain JWT tokens as described in the OAuth 2.0 Authorization Code Flow with PKCE specification.
@@ -95,8 +96,9 @@ export declare class PublicClientApplication implements IPublicClientApplication
     /**
      * Adds event callbacks to array
      * @param callback
+     * @param eventTypes
      */
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>): string | null;
     /**
      * Removes callback with provided id from callback array
      * @param callbackId

public/@azure/msal-browser/app/PublicClientApplication.d.ts

@@ -14,6 +14,7 @@ import { BrowserConfiguration, Configuration } from "../config/Configuration.js"
 import { EventCallbackFunction } from "../event/EventMessage.js";
 import { ClearCacheRequest } from "../request/ClearCacheRequest.js";
 import { AuthenticationResult } from "../response/AuthenticationResult.js";
+import { EventType } from "../event/EventType.js";
 /**
  * PublicClientNext is an early look at the planned implementation of PublicClientApplication in the next major version of MSAL.js.
  * It contains support for multiple API implementations based on the runtime environment that it is running in.
@@ -96,7 +97,7 @@ export declare class PublicClientNext implements IPublicClientApplication {
      * Adds event callbacks to array
      * @param callback
      */
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>): string | null;
     /**
      * Removes callback with provided id from callback array
      * @param callbackId

public/@azure/msal-browser/app/PublicClientNext.d.ts

@@ -10,19 +10,19 @@ import { EndSessionPopupRequest } from "../request/EndSessionPopupRequest.js";
 import { ITokenCache } from "../cache/ITokenCache.js";
 import { AuthorizationCodeRequest } from "../request/AuthorizationCodeRequest.js";
 import { BrowserConfiguration } from "../config/Configuration.js";
-import { EventHandler } from "../event/EventHandler.js";
 import { AuthenticationResult } from "../response/AuthenticationResult.js";
 import { EventCallbackFunction } from "../event/EventMessage.js";
 import { ClearCacheRequest } from "../request/ClearCacheRequest.js";
 import { InitializeApplicationRequest } from "../request/InitializeApplicationRequest.js";
+import { EventType } from "../event/EventType.js";
 export interface IController {
     initialize(request?: InitializeApplicationRequest): Promise<void>;
     acquireTokenPopup(request: PopupRequest): Promise<AuthenticationResult>;
     acquireTokenRedirect(request: RedirectRequest): Promise<void>;
     acquireTokenSilent(silentRequest: SilentRequest): Promise<AuthenticationResult>;
     acquireTokenByCode(request: AuthorizationCodeRequest): Promise<AuthenticationResult>;
     acquireTokenNative(request: PopupRequest | SilentRequest | SsoSilentRequest, apiId: ApiId, accountId?: string): Promise<AuthenticationResult>;
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>): string | null;
     removeEventCallback(callbackId: string): void;
     addPerformanceCallback(callback: PerformanceCallbackFunction): string;
     removePerformanceCallback(callbackId: string): boolean;
@@ -55,7 +55,5 @@ export interface IController {
     isBrowserEnv(): boolean;
     /** @internal */
     getPerformanceClient(): IPerformanceClient;
-    /** @internal */
-    getEventHandler(): EventHandler;
 }
 //# sourceMappingURL=IController.d.ts.map

public/@azure/msal-browser/controllers/IController.d.ts

@@ -15,6 +15,7 @@ import { NestedAppOperatingContext } from "../operatingcontext/NestedAppOperatin
 import { IBridgeProxy } from "../naa/IBridgeProxy.js";
 import { NestedAppAuthAdapter } from "../naa/mapping/NestedAppAuthAdapter.js";
 import { EventHandler } from "../event/EventHandler.js";
+import { EventType } from "../event/EventType.js";
 import { EventCallbackFunction } from "../event/EventMessage.js";
 import { AuthenticationResult } from "../response/AuthenticationResult.js";
 import { BrowserCacheManager } from "../cache/BrowserCacheManager.js";
@@ -30,11 +31,6 @@ export declare class NestedAppAuthController implements IController {
     protected readonly eventHandler: EventHandler;
     protected readonly nestedAppAuthAdapter: NestedAppAuthAdapter;
     constructor(operatingContext: NestedAppOperatingContext);
-    /**
-     * Returns the event handler instance
-     * @returns EventHandler
-     */
-    getEventHandler(): EventHandler;
     /**
      * Factory function to create a new instance of NestedAppAuthController
      * @param operatingContext
@@ -116,8 +112,9 @@ export declare class NestedAppAuthController implements IController {
     /**
      * Adds event callbacks to array
      * @param callback
+     * @param eventTypes
      */
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>): string | null;
     /**
      * Removes callback with provided id from callback array
      * @param callbackId

public/@azure/msal-browser/controllers/NestedAppAuthController.d.ts

@@ -6,6 +6,7 @@ import { RedirectRequest } from "../request/RedirectRequest.js";
 import { PopupRequest } from "../request/PopupRequest.js";
 import { SsoSilentRequest } from "../request/SsoSilentRequest.js";
 import { EventCallbackFunction } from "../event/EventMessage.js";
+import { EventType } from "../event/EventType.js";
 import { EndSessionRequest } from "../request/EndSessionRequest.js";
 import { EndSessionPopupRequest } from "../request/EndSessionPopupRequest.js";
 import { INavigationClient } from "../navigation/INavigationClient.js";
@@ -47,6 +48,7 @@ export declare class StandardController implements IController {
     private activeIframeRequest;
     private ssoSilentMeasurement?;
     private acquireTokenByCodeAsyncMeasurement?;
+    private listeningToStorageEvents;
     /**
      * @constructor
      * Constructor for the PublicClientApplication used to instantiate the PublicClientApplication object
@@ -285,7 +287,7 @@ export declare class StandardController implements IController {
      * Adds event callbacks to array
      * @param callback
      */
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>): string | null;
     /**
      * Removes callback with provided id from callback array
      * @param callbackId
@@ -313,6 +315,10 @@ export declare class StandardController implements IController {
      * Removes event listener that emits an event when a user account is added or removed from localstorage in a different browser tab or window
      */
     disableAccountStorageEvents(): void;
+    /**
+     * Emit account added/removed events when cached accounts are changed in a different tab or frame
+     */
+    protected handleAccountCacheChange(e: StorageEvent): void;
     /**
      * Gets the token cache for the application.
      */
@@ -349,10 +355,6 @@ export declare class StandardController implements IController {
      * Returns the browser env indicator
      */
     isBrowserEnv(): boolean;
-    /**
-     * Returns the event handler
-     */
-    getEventHandler(): EventHandler;
     /**
      * Generates a correlation id for a request if none is provided.
      *

public/@azure/msal-browser/controllers/StandardController.d.ts

@@ -14,9 +14,9 @@ import { AuthenticationResult } from "../response/AuthenticationResult.js";
 import { ApiId, WrapperSKU } from "../utils/BrowserConstants.js";
 import { IController } from "./IController.js";
 import { UnknownOperatingContext } from "../operatingcontext/UnknownOperatingContext.js";
-import { EventHandler } from "../event/EventHandler.js";
 import { EventCallbackFunction } from "../event/EventMessage.js";
 import { ClearCacheRequest } from "../request/ClearCacheRequest.js";
+import { EventType } from "../event/EventType.js";
 /**
  * UnknownOperatingContextController class
  *
@@ -40,10 +40,8 @@ export declare class UnknownOperatingContextController implements IController {
     protected readonly browserCrypto: ICrypto;
     protected isBrowserEnvironment: boolean;
     protected initialized: boolean;
-    protected readonly eventHandler: EventHandler;
     constructor(operatingContext: UnknownOperatingContext);
     getBrowserStorage(): BrowserCacheManager;
-    getEventHandler(): EventHandler;
     getAccount(accountFilter: AccountFilter): AccountInfo | null;
     getAccountByHomeId(homeAccountId: string): AccountInfo | null;
     getAccountByLocalId(localAccountId: string): AccountInfo | null;
@@ -56,7 +54,7 @@ export declare class UnknownOperatingContextController implements IController {
     acquireTokenByCode(request: AuthorizationCodeRequest): Promise<AuthenticationResult>;
     acquireTokenNative(request: PopupRequest | SilentRequest | Partial<Omit<CommonAuthorizationUrlRequest, "responseMode" | "codeChallenge" | "codeChallengeMethod" | "requestedClaimsHash" | "nativeBroker">>, apiId: ApiId, accountId?: string | undefined): Promise<AuthenticationResult>;
     acquireTokenByRefreshToken(commonRequest: CommonSilentFlowRequest, silentRequest: SilentRequest): Promise<AuthenticationResult>;
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>): string | null;
     removeEventCallback(callbackId: string): void;
     addPerformanceCallback(callback: PerformanceCallbackFunction): string;
     removePerformanceCallback(callbackId: string): boolean;

public/@azure/msal-browser/controllers/UnknownOperatingContextController.d.ts

@@ -1,31 +1,23 @@
-import { ICrypto, Logger } from "@azure/msal-common/browser";
+import { Logger } from "@azure/msal-common/browser";
 import { InteractionType } from "../utils/BrowserConstants.js";
 import { EventCallbackFunction, EventError, EventPayload } from "./EventMessage.js";
 import { EventType } from "./EventType.js";
 export declare class EventHandler {
     private eventCallbacks;
     private logger;
-    private browserCrypto;
-    private listeningToStorageEvents;
-    constructor(logger: Logger, browserCrypto: ICrypto);
+    constructor(logger?: Logger);
     /**
      * Adds event callbacks to array
-     * @param callback
+     * @param callback - callback to be invoked when an event is raised
+     * @param eventTypes - list of events that this callback will be invoked for, if not provided callback will be invoked for all events
+     * @param callbackId - Identifier for the callback, used to locate and remove the callback when no longer required
      */
-    addEventCallback(callback: EventCallbackFunction): string | null;
+    addEventCallback(callback: EventCallbackFunction, eventTypes?: Array<EventType>, callbackId?: string): string | null;
     /**
      * Removes callback with provided id from callback array
      * @param callbackId
      */
     removeEventCallback(callbackId: string): void;
-    /**
-     * Adds event listener that emits an event when a user account is added or removed from localstorage in a different browser tab or window
-     */
-    enableAccountStorageEvents(): void;
-    /**
-     * Removes event listener that emits an event when a user account is added or removed from localstorage in a different browser tab or window
-     */
-    disableAccountStorageEvents(): void;
     /**
      * Emits events by calling callback with event message
      * @param eventType
@@ -34,9 +26,5 @@ export declare class EventHandler {
      * @param error
      */
     emitEvent(eventType: EventType, interactionType?: InteractionType, payload?: EventPayload, error?: EventError): void;
-    /**
-     * Emit account added/removed events when cached accounts are changed in a different tab or frame
-     */
-    private handleAccountCacheChange;
 }
 //# sourceMappingURL=EventHandler.d.ts.map