phpstan fixes

Author: sc0ttkclark

components/I18n/I18n.php

@@ -133,13 +133,13 @@ public function init() {
 			 */
 
 			// Pod.
-			add_filter( 'pods_admin_setup_edit_tabs', array( $this, 'translation_tab' ), 99, 2 );
+			add_filter( 'pods_admin_setup_edit_tabs', array( $this, 'translation_tab' ), 99, 1 );
 			add_filter( 'pods_admin_setup_edit_options', array( $this, 'translation_options' ), 99, 2 );
 			// Pod Groups.
-			add_filter( 'pods_admin_setup_edit_group_tabs', array( $this, 'translation_tab' ), 99, 2 );
+			add_filter( 'pods_admin_setup_edit_group_tabs', array( $this, 'translation_tab' ), 99, 1 );
 			add_filter( 'pods_admin_setup_edit_group_options', array( $this, 'translation_options' ), 99, 2 );
 			// Pod Fields.
-			add_filter( 'pods_admin_setup_edit_field_tabs', array( $this, 'translation_tab' ), 99, 2 );
+			add_filter( 'pods_admin_setup_edit_field_tabs', array( $this, 'translation_tab' ), 99, 1 );
 			add_filter( 'pods_admin_setup_edit_field_options', array( $this, 'translation_options' ), 99, 2 );
 
 			/**
@@ -726,20 +726,21 @@ public function admin( $options, $component ) {
 		);
 
 		/**
-		 * Filter the language data
+		 * Filter the language data.
 		 *
 		 * @since 0.1.0
 		 *
-		 * @param array
+		 * @param array $data The language data.
 		 */
 		$data = apply_filters( 'pods_component_i18n_admin_data', $data );
 
 		/**
-		 * Filter the UI fields
+		 * Filter the UI fields.
 		 *
 		 * @since 0.1.0
 		 *
-		 * @param array
+		 * @param array $fields The UI fields.
+		 * @param array $data   The language data.
 		 */
 		$ui['fields'] = apply_filters( 'pods_component_i18n_admin_ui_fields', $ui['fields'], $data );
 

components/Migrate-Packages/Migrate-Packages.php

@@ -256,22 +256,6 @@ public static function import( $data, $replace = false ) {
 			}//end foreach
 		}//end if
 
-		if ( isset( $data['helpers'] ) && is_array( $data['helpers'] ) ) {
-			foreach ( $data['helpers'] as $helper_data ) {
-				$helper = self::import_pod_helper( $helper_data, $replace );
-
-				if ( ! $helper ) {
-					continue;
-				}
-
-				if ( ! isset( $found['helpers'] ) ) {
-					$found['helpers'] = array();
-				}
-
-				$found['helpers'][ $helper['name'] ] = $helper['name'];
-			}//end foreach
-		}//end if
-
 		$found = apply_filters( 'pods_packages_import', $found, $data, $replace );
 
 		if ( ! empty( $found ) ) {
@@ -817,8 +801,8 @@ public static function import_pod_page( $data, $replace = false ) {
 			];
 
 			foreach ( $excluded_args as $excluded_arg ) {
-				if ( isset( $template[ $excluded_arg ] ) ) {
-					unset( $template[ $excluded_arg ] );
+				if ( isset( $page[ $excluded_arg ] ) ) {
+					unset( $page[ $excluded_arg ] );
 				}
 			}
 		} elseif ( ! empty( $page['options'] ) ) {
@@ -841,6 +825,8 @@ public static function import_pod_page( $data, $replace = false ) {
 	/**
 	 * Handle importing of the pod helper.
 	 *
+	 * @deprecated 3.3.2
+	 *
 	 * @since 2.8.0
 	 *
 	 * @param array $data    The import data.
@@ -849,49 +835,7 @@ public static function import_pod_page( $data, $replace = false ) {
 	 * @return array|\Pods\Whatsit|false The imported object or false if failed.
 	 */
 	public static function import_pod_helper( $data, $replace = false ) {
-		if ( isset( $data['id'] ) ) {
-			unset( $data['id'] );
-		}
-
-		$helper = self::$api->load_helper( [ 'name' => $data['name'] ] );
-
-		if ( ! empty( $helper ) ) {
-			// Delete Helper if it exists
-			if ( $replace ) {
-				self::$api->delete_helper( [ 'id' => $helper['id'] ] );
-
-				$helper = [];
-			}
-		} else {
-			$helper = [];
-		}
-
-		// Backwards compatibility
-		if ( isset( $data['phpcode'] ) ) {
-			$data['code'] = $data['phpcode'];
-
-			unset( $data['phpcode'] );
-		}
-
-		if ( isset( $data['type'] ) ) {
-			if ( 'before' === $data['type'] ) {
-				$data['type'] = 'pre_save';
-			} elseif ( 'after' === $data['type'] ) {
-				$data['type'] = 'post_save';
-			}
-		}
-
-		$helper = pods_config_merge_data( $helper, $data );
-
-		if ( isset( $helper['type'] ) ) {
-			$helper['helper_type'] = $helper['type'];
-
-			unset( $helper['helper_type'] );
-		}
-
-		self::$api->save_helper( $helper );
-
-		return $helper;
+		return false;
 	}
 
 	/**
@@ -1157,28 +1101,6 @@ public static function export( $params ) {
 			}
 		}
 
-		if ( ! empty( $helper_ids ) ) {
-			$api_params = array();
-
-			if ( true !== $helper_ids ) {
-				$api_params['ids'] = (array) $helper_ids;
-			}
-
-			$export['helpers'] = array_values( self::$api->load_helpers( $api_params ) );
-
-			foreach ( $export['helpers'] as $k => $helper ) {
-				$helper = $helper->get_clean_args();
-
-				foreach ( $excluded_args as $excluded_arg ) {
-					if ( isset( $helper[ $excluded_arg ] ) ) {
-						unset( $helper[ $excluded_arg ] );
-					}
-				}
-
-				$export['helpers'][ $k ] = $helper;
-			}
-		}
-
 		/**
 		 * Allow filtering the package being exported.
 		 *

phpstan.neon

@@ -12,7 +12,7 @@ parameters:
     - ui/forms
     - ui/front
     - init.php
-    - vendor/vendor-prefixed
   excludePaths:
+    - vendor/vendor-prefixed
     - src/Pods/Integrations
     - tests