-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Open
Labels
enhancementNew feature or an improvement of an existing featureNew feature or an improvement of an existing feature
Description
Description
I was working on adding cloud writing functionality to the scala/ java bindings for polars when I came across the CloudWriter implementation for which std::io::Write is already implemented. This is great because now the dataframes can be persisted in cloud as different formats directly using the object_store crate in background.
I have implemented this in a PR, see tree and was wondering why we still use fsspec on py-polars side.
It'll be great if some one can check this out and let me know if there any issues with this approach. If it makes sense, I can raise a PR for this to persist dataframes to cloud for py-polars as well.
Approach:
- Create an instance
dyn std::io::Write- Check if destination is a cloud url to return a
CloudWriterprovided as is in polars-rs, else - return a
std::fs::File
- Check if destination is a cloud url to return a
- Pass this alongwith options to format writers like
ParquetWriter... - call
finish(...)on format writers
CC: @ritchie46
Metadata
Metadata
Assignees
Labels
enhancementNew feature or an improvement of an existing featureNew feature or an improvement of an existing feature