Decomp IsOutlaw

[slaw-22]

Do you think the name IsOutlaw is suitable?

IsOutlaw returns true when the monster behavior is one of the following:

BEHAVIOR_OUTLAW = 1,
BEHAVIOR_HIDDEN_OUTLAW = 2,  
BEHAVIOR_FLEEING_OUTLAW = 3,

However, there are two more monster behaviors that include "outlaw" in the name, but this function returns false if they were passed in:

BEHAVIOR_OUTLAW_TEAM_LEADER = 4,
BEHAVIOR_OUTLAW_TEAM_MINION = 5,

I'm not clear where the OUTLAW_TEAM behaviours are used, so it is possible the name "IsOutlaw" isn't 100% accurate.

[AnonymousRandomPerson]

BEHAVIOR_OUTLAW_TEAM_LEADER and BEHAVIOR_OUTLAW_TEAM_MINION are for a special outlaw mission type with a group of outlaws on a single-room floor, similar to a story boss. Like this:

So IsOutlaw excludes these kinds of outlaws. Perhaps something like IsRegularOutlaw? Also open to suggestions if you have a better name given the context.

[AnonymousRandomPerson]

This is likely a veneer, so this function can be called IsOutlawVeneer. If you rename IsOutlaw, remember to rename this too.

[slaw-22]

I've updated the pull request in accordance with the comments and it is ready for re-review.

Thank you @AnonymousRandomPerson. This is really useful feedback.