Decomp LoadScriptVariableRaw #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaw-22
force-pushed
the
LoadScriptVariableRaw
branch
from
59d0ccd to
b8dad60
Compare
Contributor
Author
|
I'll put this PR out for approval now. My early work on LoadScriptVariableValue is likely to lead to an improvement in clarity for the structs in scripting.h. This will come in the next PR! |
AnonymousRandomPerson
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd appreciate any early comments on this PR.
I'm not clear on the right names struct fields in scripting.h, but I might find these later! I'm also surprised that the global script var elements appear to be a different size to the local script var elements. It might be that the calling function LoadScriptVariable (not raw) might resolve this. Any thoughts on this, and any other comments would be appreciated.