Possible UB in pokemon_storage_system.c

[luckytyphlosion]

https://github.com/pret/pokeemerald/blob/9bf7a77/src/pokemon_storage_system.c#L560
static u32 sItemIconGfxBuffer[98]; think this definition causes UB, the sprite sheet size is 0x200 but this only allocates 0x188 bytes

https://github.com/pret/pokeemerald/blob/9bf7a77/src/pokemon_storage_system.c#L8735-L8737

        spriteSheet.data = sItemIconGfxBuffer;
        spriteSheet.size = 0x200;
        spriteTemplate = sSpriteTemplate_ItemIcon;

Noticed this when I tried to move this buffer to alloc'd space

[luckytyphlosion]

Edit: the size was not the issue, it is because the game tries to decompress from sItemIconGfxBuffer, even though it's in memory. this only works out because sItemIconGfxBuffer is never written to.

[luckytyphlosion]

there is another issue
at LoadSpriteSheet (from LoadCompressedSpriteSheet), the game will copy over the sheet data to vram
the problem is that this sheet data is completely uninitalized
https://github.com/pret/pokeemerald/blob/9bf7a77/src/decompress.c#L27
writes gDecompressionBuffer to data but that was never written to
https://github.com/pret/pokeemerald/blob/9bf7a77/src/sprite.c#L1499
then copies that to vram
it is never an issue because it is only done for the purpose of allocating sprite tiles for the held items in the storage