Skip to content

Commit 6c0e96f

Browse files
Fixed #7092 - Change showClearButton as false and use FilterFillIcon for row filtering
1 parent b401aff commit 6c0e96f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

packages/primevue/src/column/BaseColumn.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export default {
8080
},
8181
showClearButton: {
8282
type: Boolean,
83-
default: true
83+
default: false
8484
},
8585
showApplyButton: {
8686
type: Boolean,

packages/primevue/src/column/Column.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ export interface ColumnProps {
431431
showFilterOperator?: boolean | undefined;
432432
/**
433433
* Displays a button to clear the column filtering.
434-
* @defaultValue true
434+
* @defaultValue false
435435
*/
436436
showClearButton?: boolean | undefined;
437437
/**

packages/primevue/src/datatable/ColumnFilter.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
v-bind="{ ...getColumnPT('pcColumnFilterButton', ptmFilterMenuParams), ...filterButtonProps.filter }"
1818
>
1919
<template #icon="slotProps">
20-
<component :is="filterIconTemplate || 'FilterIcon'" :class="slotProps.class" v-bind="getColumnPT('filterMenuIcon')" />
20+
<component :is="filterIconTemplate || hasRowFilter() ? 'FilterFillIcon' : 'FilterIcon'" :class="slotProps.class" v-bind="getColumnPT('filterMenuIcon')" />
2121
</template>
2222
</Button>
2323
<Button
@@ -170,6 +170,7 @@ import { FilterOperator } from '@primevue/core/api';
170170
import BaseComponent from '@primevue/core/basecomponent';
171171
import { ConnectedOverlayScrollHandler } from '@primevue/core/utils';
172172
import FilterIcon from '@primevue/icons/filter';
173+
import FilterFillIcon from '@primevue/icons/filterfill';
173174
import FilterSlashIcon from '@primevue/icons/filterslash';
174175
import PlusIcon from '@primevue/icons/plus';
175176
import TrashIcon from '@primevue/icons/trash';
@@ -212,7 +213,7 @@ export default {
212213
},
213214
showClearButton: {
214215
type: Boolean,
215-
default: true
216+
default: false
216217
},
217218
showApplyButton: {
218219
type: Boolean,
@@ -718,6 +719,7 @@ export default {
718719
Button,
719720
Portal,
720721
FilterSlashIcon,
722+
FilterFillIcon,
721723
FilterIcon,
722724
TrashIcon,
723725
PlusIcon

0 commit comments

Comments
 (0)