-
Notifications
You must be signed in to change notification settings - Fork 232
Update contributor-guide.md,private email address securization #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Momo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 预览部署完成!访问链接: https://53d6d704.mtfwiki-preview.pages.dev
✨ 本 PR 修改了以下页面: ✨
https://53d6d704.mtfwiki-preview.pages.dev/zh-cn/docs/contributor-guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议在序号列表中插入这么长内容的 warning,非常影响阅读体验。另外自己通过GitHub贡献本来就有很多方面均有可能泄露个人信息,包括电子邮件地址和exif信息等,建议简要一句话叙述即可。相比exif信息泄露,电子邮件地址泄露的后果一般要轻微的多。另外需要说明的是,由于Git的分布式特性,commit中署名的电子邮件地址未必是由署名的作者所提交的。
Signed-off-by: Momo <[email protected]>
已修改,感谢反馈 |
|
其实我有点想拒绝这个 PR,我觉得这句话应该已经够了:“该方法的过程将是公开的,请注意处理隐私数据,如果不会处理隐私数据,请通过邮件方式贡献内容”。而且 GitHub 注册账号在线编辑会默认公开电子邮件吗?这个还需要确认一下。 |
|
提醒git記錄有電郵還是有必要的吧,而且github也有一鍵隱藏的選項可供使用 |
| ## 贡献方式 {#method} | ||
|
|
||
| 1. 会 GitHub 操作,直接 <abbr title="Pull Request">PR</abbr> 或 通过 {{< shields/github-issue "project-trans/mtf-wiki" >}}(该方法的过程将是公开的,请注意处理隐私数据,如果不会处理隐私数据,请通过邮件方式贡献内容) | ||
| {{< notice warning "注意事项" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {{< notice warning "注意事项" >}} |
| 1. 会 GitHub 操作,直接 <abbr title="Pull Request">PR</abbr> 或 通过 {{< shields/github-issue "project-trans/mtf-wiki" >}}(该方法的过程将是公开的,请注意处理隐私数据,如果不会处理隐私数据,请通过邮件方式贡献内容) | ||
| {{< notice warning "注意事项" >}} | ||
| 如果你在Github网页上编辑,Github默认会把你注册用的电邮地址放在你编辑的内容上的“commit message”里面;一旦编辑完并提交了“pull request”请求,**所有人都可以看得到这个地址** | ||
| {{< /notice >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {{< /notice >}} | |
增加一处提醒,提醒贡献者自己注册github的电邮有可能会被公开,以及技术手段以预防这一点。