#add_show_tools_partial should not overwrite an existing method

Author: cbeer

lib/blacklight/catalog/component_configuration.rb

@@ -34,8 +34,10 @@ module ClassMethods
       #                             The proc will receive the action configuration and the document or documents for the action.
       def add_show_tools_partial name, opts = {}
         blacklight_config.add_show_tools_partial(name, opts)
+
         define_method name do
           @response, @documents = action_documents
+
           if request.post? and
               opts[:callback] and
               (opts[:validator].blank? || self.send(opts[:validator]))
@@ -54,7 +56,7 @@ def add_show_tools_partial name, opts = {}
               format.js { render :layout => false }
             end
           end
-        end
+        end unless method_defined? name
       end
 
       ##

spec/lib/blacklight/catalog/component_configuration_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe Blacklight::Catalog::ComponentConfiguration do
+  subject do
+    Class.new do
+      include Blacklight::Configurable
+      include Blacklight::Catalog::ComponentConfiguration
+
+      def some_existing_action
+        1
+      end
+    end
+  end
+
+  describe ".add_show_tools_partial" do
+    it "should define an action method" do
+      subject.add_show_tools_partial :xyz
+      expect(subject.new).to respond_to :xyz
+    end
+
+    it "should not replace an existing method" do
+      subject.add_show_tools_partial :some_existing_action
+      expect(subject.new.some_existing_action).to eq 1
+    end
+  end
+
+  
+
+end