Merge pull request #3758 from projectblacklight/solr_repository_no_args

Allow Blacklight::Solr::Repository#search to be called with no args

Author: seanaery

lib/blacklight/solr/repository.rb

@@ -30,7 +30,7 @@ def search pos_params = nil, path: nil, params: nil, **kwargs
         Blacklight.deprecation.warn("Passing positional arguments to search() is deprecated. Use the params kwarg instead.")
       end
 
-      request_params = (params || pos_params).reverse_merge(kwargs).reverse_merge({ qt: blacklight_config.qt })
+      request_params = (params || pos_params || {}).reverse_merge(kwargs).reverse_merge({ qt: blacklight_config.qt })
 
       send_and_receive(path || default_search_path(request_params), request_params)
     end

spec/models/blacklight/solr/repository_spec.rb

@@ -87,6 +87,12 @@
       expect(subject.search(params: {})).to be_a Blacklight::Solr::Response
     end
 
+    it "can be called with no args" do
+      blacklight_config.solr_path = 'xyz'
+      allow(subject.connection).to receive(:send_and_receive).with('xyz', anything).and_return(mock_response)
+      expect(subject.search).to be_a Blacklight::Solr::Response
+    end
+
     it "uses the default solr path" do
       allow(subject.connection).to receive(:send_and_receive).with('select', anything).and_return(mock_response)
       expect(subject.search(params: {})).to be_a Blacklight::Solr::Response