-
Notifications
You must be signed in to change notification settings - Fork 259
Document the CLI argument environment variables #16725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Documentation ReviewThank you for this contribution! The content is clear and helpful. I've identified a few issues that need to be addressed: Issues FoundLine 571: Version formatting Line 584: Personal pronoun usage Line 586 (end of file): Missing trailing newline SummaryThe content is well-structured with clear examples and a helpful table. Once the above issues are addressed, this will be a solid addition to the documentation. If you'd like me to review the changes again after updates, mention @claude in a comment. |
|
Hello @claude, please re-review and give me any further feedback as if you were a pirate |
|
Claude finished @i-am-tom's task —— View job Ahoy There, Matey! Documentation ReviewShiver me timbers! I've completed me review of yer pull request, and I be pleased to report that ye've done a fine job addressin' the previous concerns! Tasks
What Be Fixed From Last TimeArrr! Ye've successfully addressed all three issues from the previous review:
New Treasures I've DiscoveredNow, let me cast me eye over the rest of yer documentation... Line 571: A wee bit o' polish needed The version reference be lookin' good without the backticks on the version number, but I be noticin' it could use the standard version link format. However, since this be followin' the same pattern as other version references in the document (like lines 181, 315, 328, etc.), it be consistent with the rest of the document. So this be fine as she stands! Lines 577-582: The table be beautiful! Yer table be clear as Caribbean waters, matey! The examples show the mapping between CLI arguments and environment variables perfectly. Any landlubber could follow these instructions! Line 584-586: Smooth sailin'! The prose be well-written and informative. Ye've explained the boolean argument options clearly, and the link to the release article be a fine addition for scallywags seekin' more information. The Final VerdictAPPROVED, YE SCURVY DOG! 🏴☠️ This be a solid contribution to the documentation, it is! The content be clear, the examples be helpful, and all the previous issues have been properly addressed. Ye've followed the repository's style guidelines like a true buccaneer followin' the pirate code. The only thing left be to get this treasure merged into the main branch, so other sailors can benefit from yer fine work! Fair winds and followin' seas to ye! P.S. - If ye be needin' another review after any changes, just hoist the @claude flag again, and I'll come sailin' back! | |
|
Your site preview for commit 264575d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16725-264575db.s3-website.us-west-2.amazonaws.com. |
Proposed changes
Alongside the blog post, we should add a note the docs to explain how to use them. It's a first docs contribution for me, so I'm not sure what the rules or guidelines here are, so please let me know if I'm missing something!