Skip to content

Conversation

@i-am-tom
Copy link
Contributor

@i-am-tom i-am-tom commented Dec 3, 2025

Proposed changes

Alongside the blog post, we should add a note the docs to explain how to use them. It's a first docs contribution for me, so I'm not sure what the rules or guidelines here are, so please let me know if I'm missing something!

@claude
Copy link
Contributor

claude bot commented Dec 3, 2025

Documentation Review

Thank you for this contribution! The content is clear and helpful. I've identified a few issues that need to be addressed:

Issues Found

Line 571: Version formatting
The version reference should use standard formatting without backticks around the version number.

As of v3.208.0, all Pulumi CLI arguments can be set via environment variables.

Line 584: Personal pronoun usage
Documentation should avoid first-person plural pronouns like "we." Use second person ("you") or passive voice instead.

Note that you can specify boolean arguments either with `true` and `false` or `1` and `0`. For more information, as well as some practical examples, see the [release article](https://www.pulumi.com/blog/controlling-the-cli-through-environment-variables/).

Line 586 (end of file): Missing trailing newline
According to repository standards (AGENTS.md), all Markdown files must end with a newline. The diff shows "No newline at end of file" which needs to be corrected.

Summary

The content is well-structured with clear examples and a helpful table. Once the above issues are addressed, this will be a solid addition to the documentation.


If you'd like me to review the changes again after updates, mention @claude in a comment.

@i-am-tom
Copy link
Contributor Author

i-am-tom commented Dec 3, 2025

Hello @claude, please re-review and give me any further feedback as if you were a pirate

@claude
Copy link
Contributor

claude bot commented Dec 3, 2025

Claude finished @i-am-tom's task —— View job


Ahoy There, Matey! Documentation Review

Shiver me timbers! I've completed me review of yer pull request, and I be pleased to report that ye've done a fine job addressin' the previous concerns!

Tasks

  • Read the modified file to see current state
  • Check if previous review issues were addressed
  • Look for any new issues
  • Provide pirate-themed review feedback

What Be Fixed From Last Time

Arrr! Ye've successfully addressed all three issues from the previous review:

  1. Version formattin' (Line 571) - Ye've removed the backticks around the version number, just as instructed. Well done, sailor!
  2. Personal pronoun usage (Line 584-586) - Ye've replaced "we" with "you," makin' it proper documentation speak. That be shipshape!
  3. Trailing newline - Aye, the file now ends with a proper newline at line 587. The scallywag "No newline at end of file" warning be gone!

New Treasures I've Discovered

Now, let me cast me eye over the rest of yer documentation...

Line 571: A wee bit o' polish needed

The version reference be lookin' good without the backticks on the version number, but I be noticin' it could use the standard version link format. However, since this be followin' the same pattern as other version references in the document (like lines 181, 315, 328, etc.), it be consistent with the rest of the document. So this be fine as she stands!

Lines 577-582: The table be beautiful!

Yer table be clear as Caribbean waters, matey! The examples show the mapping between CLI arguments and environment variables perfectly. Any landlubber could follow these instructions!

Line 584-586: Smooth sailin'!

The prose be well-written and informative. Ye've explained the boolean argument options clearly, and the link to the release article be a fine addition for scallywags seekin' more information.

The Final Verdict

APPROVED, YE SCURVY DOG! 🏴☠️

This be a solid contribution to the documentation, it is! The content be clear, the examples be helpful, and all the previous issues have been properly addressed. Ye've followed the repository's style guidelines like a true buccaneer followin' the pirate code.

The only thing left be to get this treasure merged into the main branch, so other sailors can benefit from yer fine work!

Fair winds and followin' seas to ye!


P.S. - If ye be needin' another review after any changes, just hoist the @claude flag again, and I'll come sailin' back!


|

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants