Support writing SIGNED_RATIONAL tag types

Author: radarhere

Tests/test_file_libtiff.py

@@ -355,6 +355,22 @@ def test_subifd(self, tmp_path: Path) -> None:
             # Should not segfault
             im.save(outfile)
 
+    def test_signed_rational(
+        self, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+    ) -> None:
+        monkeypatch.setattr(TiffImagePlugin, "WRITE_LIBTIFF", True)
+
+        ifd = TiffImagePlugin.ImageFileDirectory_v2()
+        ifd[37000] = 100
+        ifd.tagtype[37000] = TiffTags.SIGNED_RATIONAL
+
+        out = tmp_path / "temp.tif"
+        im = Image.new("L", (1, 1))
+        im.save(out, tiffinfo=ifd)
+
+        with Image.open(out) as reloaded:
+            assert reloaded.tag_v2[37000] == 100
+
     def test_ifd(self, monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> None:
         monkeypatch.setattr(TiffImagePlugin, "WRITE_LIBTIFF", True)
 

src/encode.c

@@ -990,10 +990,6 @@ PyImaging_LibTiffEncoderNew(PyObject *self, PyObject *args) {
                 status = ImagingLibTiffSetField(
                     &encoder->state, (ttag_t)key_int, (FLOAT32)PyFloat_AsDouble(value)
                 );
-            } else if (type == TIFF_DOUBLE) {
-                status = ImagingLibTiffSetField(
-                    &encoder->state, (ttag_t)key_int, (FLOAT64)PyFloat_AsDouble(value)
-                );
             } else if (type == TIFF_SBYTE) {
                 status = ImagingLibTiffSetField(
                     &encoder->state, (ttag_t)key_int, (INT8)PyLong_AsLong(value)
@@ -1002,11 +998,14 @@ PyImaging_LibTiffEncoderNew(PyObject *self, PyObject *args) {
                 status = ImagingLibTiffSetField(
                     &encoder->state, (ttag_t)key_int, PyBytes_AsString(value)
                 );
-            } else if (type == TIFF_RATIONAL) {
-                status = ImagingLibTiffSetField(
-                    &encoder->state, (ttag_t)key_int, (FLOAT64)PyFloat_AsDouble(value)
-                );
-            } else if (type == TIFF_LONG8) {
+            } else if (type == TIFF_DOUBLE) || type == TIFF_SRATIONAL || type == TIFF_RATIONAL) {
+                    status = ImagingLibTiffSetField(
+                        &encoder->state,
+                        (ttag_t)key_int,
+                        (FLOAT64)PyFloat_AsDouble(value)
+                    );
+                }
+            else if (type == TIFF_LONG8) {
                 status = ImagingLibTiffSetField(
                     &encoder->state, (ttag_t)key_int, (uint64_t)PyLong_AsLongLong(value)
                 );