Skip to content

Commit a0c8a54

Browse files
authored
Merge pull request #301 from bitdotioinc/boyd/user_model_default_manager
2 parents cafdafc + fbf316d commit a0c8a54

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

social_django/storage.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def user_exists(cls, *args, **kwargs):
4949
"""
5050
if 'username' in kwargs:
5151
kwargs[cls.username_field()] = kwargs.pop('username')
52-
return cls.user_model().objects.filter(*args, **kwargs).exists()
52+
return cls.user_model()._default_manager.filter(*args, **kwargs).exists()
5353

5454
@classmethod
5555
def get_username(cls, user):
@@ -76,15 +76,15 @@ def create_user(cls, *args, **kwargs):
7676
# stays undamaged by wrapping the create in an atomic.
7777
using = router.db_for_write(cls.user_model())
7878
with transaction.atomic(using=using):
79-
user = cls.user_model().objects.create_user(*args, **kwargs)
79+
user = cls.user_model()._default_manager.create_user(*args, **kwargs)
8080
else:
81-
user = cls.user_model().objects.create_user(*args, **kwargs)
81+
user = cls.user_model()._default_manager.create_user(*args, **kwargs)
8282
except IntegrityError as exc:
8383
# If email comes in as None it won't get found in the get
8484
if kwargs.get('email', True) is None:
8585
kwargs['email'] = ''
8686
try:
87-
user = cls.user_model().objects.get(*args, **kwargs)
87+
user = cls.user_model()._default_manager.get(*args, **kwargs)
8888
except cls.user_model().DoesNotExist:
8989
raise exc
9090
return user
@@ -94,15 +94,15 @@ def get_user(cls, pk=None, **kwargs):
9494
if pk:
9595
kwargs = {'pk': pk}
9696
try:
97-
return cls.user_model().objects.get(**kwargs)
97+
return cls.user_model()._default_manager.get(**kwargs)
9898
except cls.user_model().DoesNotExist:
9999
return None
100100

101101
@classmethod
102102
def get_users_by_email(cls, email):
103103
user_model = cls.user_model()
104104
email_field = getattr(user_model, 'EMAIL_FIELD', 'email')
105-
return user_model.objects.filter(**{email_field + '__iexact': email})
105+
return user_model._default_manager.filter(**{email_field + '__iexact': email})
106106

107107
@classmethod
108108
def get_social_auth(cls, provider, uid):

social_django/strategy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def from_session_value(self, val):
147147
if isinstance(val, dict) and 'pk' in val and 'ctype' in val:
148148
ctype = ContentType.objects.get_for_id(val['ctype'])
149149
ModelClass = ctype.model_class()
150-
val = ModelClass.objects.get(pk=val['pk'])
150+
val = ModelClass._default_manager.get(pk=val['pk'])
151151
return val
152152

153153
def get_language(self):

tests/test_admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class SocialAdminTest(TestCase):
88
@classmethod
99
def setUpTestData(cls):
1010
User = get_user_model()
11-
User.objects.create_superuser(
11+
User._default_manager.create_superuser(
1212
username='admin', email='[email protected]', first_name='Admin',
1313
password='super-duper-test'
1414
)

tests/test_models.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ class TestSocialAuthUser(TestCase):
1414
def test_user_relationship_none(self):
1515
"""Accessing User.social_user outside of the pipeline doesn't work"""
1616
User = get_user_model()
17-
user = User.objects.create_user(username="randomtester")
17+
user = User._default_manager.create_user(username="randomtester")
1818
with self.assertRaises(AttributeError):
1919
user.social_user
2020

2121
def test_user_existing_relationship(self):
2222
"""Accessing User.social_user outside of the pipeline doesn't work"""
2323
User = get_user_model()
24-
user = User.objects.create_user(username="randomtester")
24+
user = User._default_manager.create_user(username="randomtester")
2525
UserSocialAuth.objects.create(user=user,
2626
provider='my-provider',
2727
uid='1234')
@@ -30,7 +30,7 @@ def test_user_existing_relationship(self):
3030

3131
def test_get_social_auth(self):
3232
User = get_user_model()
33-
user = User.objects.create_user(username="randomtester")
33+
user = User._default_manager.create_user(username="randomtester")
3434
user_social = UserSocialAuth.objects.create(user=user,
3535
provider='my-provider',
3636
uid='1234')
@@ -62,15 +62,15 @@ def test_cleanup(self):
6262
class TestUserSocialAuth(TestCase):
6363
def setUp(self):
6464
self.user_model = get_user_model()
65-
self.user = self.user_model.objects.create_user(
65+
self.user = self.user_model._default_manager.create_user(
6666
username='randomtester', email='[email protected]')
6767
self.usa = UserSocialAuth.objects.create(
6868
user=self.user, provider='my-provider', uid='1234')
6969

7070
def test_changed(self):
7171
self.user.email = eml = '[email protected]'
7272
UserSocialAuth.changed(user=self.user)
73-
db_eml = self.user_model.objects.get(username=self.user.username).email
73+
db_eml = self.user_model._default_manager.get(username=self.user.username).email
7474
self.assertEqual(db_eml, eml)
7575

7676
def test_set_extra_data(self):
@@ -117,7 +117,7 @@ def test_create_user_custom_username(self, *args):
117117
@mock.patch('social_django.storage.transaction', spec=[])
118118
def test_create_user_without_transaction_atomic(self, *args):
119119
UserSocialAuth.create_user(username='test')
120-
self.assertTrue(self.user_model.objects.filter(
120+
self.assertTrue(self.user_model._default_manager.filter(
121121
username='test').exists())
122122

123123
def test_get_user(self):

tests/test_strategy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def test_random_string(self):
5151

5252
def test_session_value(self):
5353
user_model = get_user_model()
54-
user = user_model.objects.create_user(username="test")
54+
user = user_model._default_manager.create_user(username="test")
5555
ctype = ContentType.objects.get_for_model(user_model)
5656

5757
val = self.strategy.to_session_value(val=user)

tests/test_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def test_complete(self, mock_request):
3939
@mock.patch('social_core.backends.base.BaseAuth.request')
4040
def test_disconnect(self, mock_request):
4141
user_model = get_user_model()
42-
user = user_model.objects.create_user(username='test', password='pwd')
42+
user = user_model._default_manager.create_user(username='test', password='pwd')
4343
UserSocialAuth.objects.create(user=user, provider='facebook')
4444
self.client.login(username='test', password='pwd')
4545

0 commit comments

Comments
 (0)