Merge pull request #50916 from aureamunoz/allow-forcing-required-value-true

Allow forcing a RequestParam explicitly required

Author: geoand

extensions/spring-web/resteasy-reactive/deployment/src/main/java/io/quarkus/spring/web/resteasy/reactive/deployment/SpringWebResteasyReactiveProcessor.java

@@ -303,15 +303,6 @@ public void transform(TransformationContext transformationContext) {
                             AnnotationValue defaultValue = annotation.value("defaultValue");
                             if (defaultValue != null) {
                                 defaultValueStr = defaultValue.asString();
-                            } else {
-                                AnnotationValue requiredValue = annotation.value("required");
-                                if (requiredValue != null) {
-                                    if (requiredValue.asBoolean()) {
-                                        throw new IllegalArgumentException(
-                                                "Using required @RequestMapping is not supported. Offending method is '"
-                                                        + methodInfo.declaringClass().name() + "#" + methodInfo.name() + "'");
-                                    }
-                                }
                             }
                             if (defaultValueStr != null) {
                                 transform.add(create(DEFAULT_VALUE, annotation.target(),

extensions/spring-web/resteasy-reactive/tests/src/test/java/io/quarkus/spring/web/requestparam/RequestParamController.java

@@ -80,13 +80,19 @@ public String getFoosParamRequired(@RequestParam String id) {
         throw new IllegalStateException("Unexpected state. Should have not been called");
     }
 
+    @GetMapping("/api/foos/paramExplicitlyRequired")
+    public String getFoosParamExplicitlyRequired(@RequestParam(required = true) String id) {
+        throw new IllegalStateException("Unexpected state. Should have not been called");
+    }
+
     @RestControllerAdvice
     public static class RestExceptionHandler {
 
         @ExceptionHandler(WebApplicationException.class)
         public ResponseEntity<Object> handleException(Exception ex) {
             return new ResponseEntity<>(ex.getMessage(), HttpStatus.BAD_REQUEST);
         }
+
     }
 
 }

extensions/spring-web/resteasy-reactive/tests/src/test/java/io/quarkus/spring/web/requestparam/RequestParamControllerTest.java

@@ -129,6 +129,10 @@ public void shouldFailWithBadRequestWhenMissingMandatoryParam() throws Exception
         when().get("/api/foos/paramRequired")
                 .then()
                 .statusCode(400).body(containsString("Missing required param in method"));
+
+        when().get("/api/foos/paramExplicitlyRequired")
+                .then()
+                .statusCode(400).body(containsString("Missing required param in method"));
     }
 
 }