Skip to content

Commit 1f288ab

Browse files
Make sure to set PROJECT_VERSION for Windows
otherwise the version will be set to the current commit SHA in the rabbitmq-packaging repo.
1 parent 48cc3c6 commit 1f288ab

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

.github/workflows/reusable-release-workflow.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -431,12 +431,12 @@ jobs:
431431
cd rabbitmq-packaging
432432
# IMPORTANT: PRODUCT_VERSION must use the A.B.C.D format where every component is a positive integer.
433433
# This is an MSI and makensis build tooling requirement.
434-
export VERSION=${{ env.FULL_VERSION }} PRODUCT_VERSION=${{ env.WINDOWS_INSTALLER_VERSION }}
435-
VERSION=${{ env.FULL_VERSION }} PRODUCT_VERSION=${{ env.WINDOWS_INSTALLER_VERSION }} gmake package-windows \
436-
RABBITMQ_PACKAGING_REPO="." \
437-
SOURCE_DIST_FILE=../rabbitmq-server/PACKAGES/rabbitmq-server-${{ env.FULL_VERSION }}.tar.xz \
438-
VERSION=${{ env.FULL_VERSION }} \
439-
PRODUCT_VERSION=${{ env.WINDOWS_INSTALLER_VERSION }}
434+
gmake package-windows \
435+
RABBITMQ_PACKAGING_REPO="." \
436+
SOURCE_DIST_FILE=../rabbitmq-server/PACKAGES/rabbitmq-server-${{ env.FULL_VERSION }}.tar.xz \
437+
VERSION=${{ env.FULL_VERSION }} \
438+
PROJECT_VERSION=${{ env.FULL_VERSION }} \
439+
PRODUCT_VERSION=${{ env.WINDOWS_INSTALLER_VERSION }}
440440
cd ..
441441
ls -lha PACKAGES/
442442
@@ -462,11 +462,12 @@ jobs:
462462
cd rabbitmq-packaging
463463
# IMPORTANT: PRODUCT_VERSION must use the A.B.C.D format where every component is a positive integer.
464464
# This is an MSI and makensis build tooling requirement.
465-
VERSION=${{ env.FULL_VERSION }} PRODUCT_VERSION=${{ env.WINDOWS_INSTALLER_VERSION }} gmake package-windows \
466-
RABBITMQ_PACKAGING_REPO="." \
467-
SOURCE_DIST_FILE=../rabbitmq-server/PACKAGES/rabbitmq-server-${{ env.FULL_VERSION }}.tar.xz \
468-
VERSION=${{ env.FULL_VERSION }} \
469-
PRODUCT_VERSION=${{ env.WINDOWS_INSTALLER_VERSION }}
465+
gmake package-windows \
466+
RABBITMQ_PACKAGING_REPO="." \
467+
SOURCE_DIST_FILE=../rabbitmq-server/PACKAGES/rabbitmq-server-${{ env.FULL_VERSION }}.tar.xz \
468+
VERSION=${{ env.FULL_VERSION }} \
469+
PROJECT_VERSION=${{ env.FULL_VERSION }} \
470+
PRODUCT_VERSION=${{ env.WINDOWS_INSTALLER_VERSION }}
470471
cd ..
471472
ls -lha PACKAGES/
472473
- name: Remove signing artifacts

0 commit comments

Comments
 (0)